Skip to content

Commit c5606cf

Browse files
@W-21006714: singleServerCustomTabActivity is malfunctioning (#2831)
1 parent b600d86 commit c5606cf

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,6 +1526,7 @@ open class LoginActivity : FragmentActivity() {
15261526
if (activity.viewModel.singleServerCustomTabActivity) {
15271527
// Show blank page and spinner until PKCE is done.
15281528
activity.viewModel.loginUrl.value = ABOUT_BLANK
1529+
finish()
15291530
} else {
15301531
// Don't show server picker if we are re-authenticating with cookie.
15311532
activity.clearWebView(showServerPicker = !activity.sharedBrowserSession)

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginViewModel.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ open class LoginViewModel(val bootConfig: BootConfig) : ViewModel() {
515515
private val scope: CoroutineScope = viewModelScope,
516516
) : Observer<String?> {
517517
override fun onChanged(value: String?) {
518-
if (!sdkManager.isBrowserLoginEnabled && !viewModel.isUsingFrontDoorBridge && value != null) {
518+
if (!sdkManager.isBrowserLoginEnabled && !singleServerCustomTabActivity && !viewModel.isUsingFrontDoorBridge && value != null) {
519519
val valueUrl = value.toUri()
520520
val loginUrl = viewModel.loginUrl.value?.toUri()
521521
val isNewServer = loginUrl?.host != valueUrl.host || loginUrl?.path != valueUrl.path
@@ -563,7 +563,8 @@ open class LoginViewModel(val bootConfig: BootConfig) : ViewModel() {
563563
private val scope: CoroutineScope = viewModelScope,
564564
) : Observer<String> {
565565
override fun onChanged(value: String) {
566-
if (sdkManager.isBrowserLoginEnabled && !viewModel.isUsingFrontDoorBridge) {
566+
val useBrowserCustomTab = sdkManager.isBrowserLoginEnabled || singleServerCustomTabActivity
567+
if (useBrowserCustomTab && !viewModel.isUsingFrontDoorBridge) {
567568
scope.launch {
568569
viewModel.browserCustomTabUrl.value = viewModel.getAuthorizationUrl(
569570
server = value

0 commit comments

Comments
 (0)