Skip to content

Commit f3fad52

Browse files
@W-21933885: [MSDK Android] App Attestation Implementation (Restore Previous Attestation Encoding)
1 parent 4029772 commit f3fad52

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/AppAttestationClient.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,6 @@ internal data class OAuthAuthorizationAttestation(
250250
/**
251251
* Returns a Base64-encoded JSON representation of this object
252252
*/
253-
fun toBase64String(): String? = Base64.getUrlEncoder().withoutPadding().encodeToString(Json.encodeToString(serializer(), this).encodeToByteArray())
253+
fun toBase64String(): String? = Base64.getEncoder().encodeToString(Json.encodeToString(serializer(), this).encodeToByteArray())
254254
}
255255

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/OAuth2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ public static TokenEndpointResponse makeTokenEndpointRequest(HttpAccess httpAcce
583583
final String challenge = appAttestationClient != null ? appAttestationClient.fetchMobileAppAttestationChallenge() : null;
584584
final String attestationValue = challenge != null ? appAttestationClient.createAppAttestationBlocking(challenge) : null;
585585
if (attestationValue != null) {
586-
sb.append(AND).append(ATTESTATION).append(EQUAL).append(Uri.encode(attestationValue));
586+
sb.append(AND).append(ATTESTATION).append(EQUAL).append(attestationValue);
587587
}
588588

589589
final String refreshPath = sb.toString();

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/AppAttestationClientTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ class AppAttestationClientTest {
417417
const val TEST_CHALLENGE_VALUE = "__TEST_CHALLENGE_VALUE__"
418418
const val TEST_INTEGRITY_TOKEN = "__TEST_INTEGRITY_TOKEN__"
419419
const val EXPECTED_ATTESTATION_RESULT =
420-
"eyJhdHRlc3RhdGlvbklkIjoiMTIzNDU2IiwiYXR0ZXN0YXRpb25EYXRhIjoiWDE5VVJWTlVYMGxPVkVWSFVrbFVXVjlVVDB0RlRsOWYifQ"
420+
"eyJhdHRlc3RhdGlvbklkIjoiMTIzNDU2IiwiYXR0ZXN0YXRpb25EYXRhIjoiWDE5VVJWTlVYMGxPVkVWSFVrbFVXVjlVVDB0RlRsOWYifQ=="
421421
const val TEST_ATTESTATION_ID = "123456"
422422
const val TEST_ATTESTATION_DATA = "W19VVlJTVVhNbExPVkVWSFVrbFVXVjlVVDB0RlRsOWYifQ=="
423423
const val TEST_ATTESTATION_JSON =

0 commit comments

Comments
 (0)