Skip to content

Commit 2dbcda9

Browse files
committed
open pr: handle OpenSSL's underscores correctly
The most recent OpenSSL release was announced with underscores in their version numbers, for some reason, e.g. 1_1_1t. We already have logic to turn them into dots, but we only handled the first underscore (reporting a version number `1.1_1t`, see git-for-windows/MSYS2-packages#83 for an example with a botched version). Let's handle all of them underscores, not just the first one. Even if OpenSSL seems to have re-announced the version with dots now: git-for-windows/git#4277 (comment) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent c3ef847 commit 2dbcda9

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

GitForWindowsHelper/component-updates.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ const guessComponentUpdateDetails = (title, body) => {
1212

1313
version = version
1414
.replace(/^(GCM |openssl-|OpenSSL_|v|V_|GnuTLS |tig-|Heimdal |cygwin-|PCRE2-|Bash-)/, '')
15-
.replace(/_|\s+patch\s+/, '.')
15+
.replace(/\s+patch\s+/, '.')
16+
.replace(/_/g, '.')
1617
.replace(/-release$/, '')
1718

1819
return { package_name, version }

0 commit comments

Comments
 (0)