Skip to content

Commit 449eca7

Browse files
committed
guessReleaseNotes(): also return the package and version
We will use this information to avoid adding release notes for not-yet-deployed packages. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 1e53e13 commit 449eca7

2 files changed

Lines changed: 22 additions & 8 deletions

File tree

GitForWindowsHelper/component-updates.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,13 @@ const guessReleaseNotes = async (context, issue) => {
9393
const url = await matchURL()
9494
if (!url) throw new Error(`Could not determine URL from issue ${issue.number}`)
9595

96-
package_name = prettyPackageName(package_name.replace(/^mingw-w64-/, ''))
96+
const prettyName = prettyPackageName(package_name.replace(/^mingw-w64-/, ''))
9797

9898
return {
9999
type: 'feature',
100-
message: `Comes with [${package_name} v${version}](${url}).`
100+
message: `Comes with [${prettyName} v${version}](${url}).`,
101+
package: package_name,
102+
version
101103
}
102104
}
103105

__tests__/component-updates.test.js

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ test('guessReleaseNotes()', async () => {
6363
body: bashTicketBody
6464
})).toEqual({
6565
type: 'feature',
66-
message: 'Comes with [Bash v5.2.15](https://git.savannah.gnu.org/cgit/bash.git/commit/?id=ec8113b9861375e4e17b3307372569d429dec814).'
66+
message: 'Comes with [Bash v5.2.15](https://git.savannah.gnu.org/cgit/bash.git/commit/?id=ec8113b9861375e4e17b3307372569d429dec814).',
67+
package: 'bash',
68+
version: '5.2.15'
6769
})
6870

6971
expect(await guessReleaseNotes(context, {
@@ -76,7 +78,9 @@ Added the security advisory.[GNUTLS-SA-2020-07-14](security-new.html#GNUTLS-SA-2
7678
http://www.gnutls.org/news.html#2023-02-10`
7779
})).toEqual({
7880
type: 'feature',
79-
message: 'Comes with [GNU TLS v3.8.0](https://lists.gnupg.org/pipermail/gnutls-help/2023-February/004816.html).'
81+
message: 'Comes with [GNU TLS v3.8.0](https://lists.gnupg.org/pipermail/gnutls-help/2023-February/004816.html).',
82+
package: 'gnutls',
83+
version: '3.8.0'
8084
})
8185

8286
expect(await guessReleaseNotes(context, {
@@ -85,7 +89,9 @@ http://www.gnutls.org/news.html#2023-02-10`
8589
body: `\nhttps://github.com/Perl/perl5/releases/tag/v5.36.1`
8690
})).toEqual({
8791
type: 'feature',
88-
message: 'Comes with [Perl v5.36.1](http://search.cpan.org/dist/perl-5.36.1/pod/perldelta.pod).'
92+
message: 'Comes with [Perl v5.36.1](http://search.cpan.org/dist/perl-5.36.1/pod/perldelta.pod).',
93+
package: 'perl',
94+
version: '5.36.1'
8995
})
9096

9197
expect(await guessReleaseNotes(context, {
@@ -94,7 +100,9 @@ http://www.gnutls.org/news.html#2023-02-10`
94100
body: `\nhttps://github.com/curl/curl/releases/tag/curl-8_1_1`
95101
})).toEqual({
96102
type: 'feature',
97-
message: 'Comes with [cURL v8.1.1](https://curl.se/changes.html#8_1_1).'
103+
message: 'Comes with [cURL v8.1.1](https://curl.se/changes.html#8_1_1).',
104+
package: 'curl',
105+
version: '8.1.1'
98106
})
99107

100108
expect(await guessReleaseNotes(context, {
@@ -103,7 +111,9 @@ http://www.gnutls.org/news.html#2023-02-10`
103111
body: `\nhttps://github.com/openssl/openssl/releases/tag/OpenSSL_1_1_1u`
104112
})).toEqual({
105113
type: 'feature',
106-
message: 'Comes with [OpenSSL v1.1.1u](https://www.openssl.org/news/openssl-1.1.1-notes.html).'
114+
message: 'Comes with [OpenSSL v1.1.1u](https://www.openssl.org/news/openssl-1.1.1-notes.html).',
115+
package: 'openssl',
116+
version: '1.1.1u'
107117
})
108118

109119
expect(await guessReleaseNotes(context, {
@@ -112,6 +122,8 @@ http://www.gnutls.org/news.html#2023-02-10`
112122
body: `\nhttps://github.com/openssl/openssl/releases/tag/openssl-3.1.1`
113123
})).toEqual({
114124
type: 'feature',
115-
message: 'Comes with [OpenSSL v3.1.1](https://www.openssl.org/news/openssl-3.1-notes.html).'
125+
message: 'Comes with [OpenSSL v3.1.1](https://www.openssl.org/news/openssl-3.1-notes.html).',
126+
package: 'openssl',
127+
version: '3.1.1'
116128
})
117129
})

0 commit comments

Comments
 (0)