/git-artifacts: add the git-artifacts runs to the PR comment more reliably

When `/git-artifacts` has to trigger a `tag-git` run first, the actual
`git-artifacts-<arch>` jobs are triggered as "cascading runs". At that
stage, the connection to the original PR comment ID is lost, and
therefore that comment is no longer updated to link to those
`git-artifacts-<arch>` runs.

With this patch, GitForWindowsHelper learns to find that PR comment ID
when a completed `tag-git` check run triggers the `git-artifacts-` runs
and then to update that comment accordingly.

This addresses #38

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/cascading-runs.js

@@ -114,7 +114,17 @@ const cascadingRuns = async (context, req) => {
                 throw new Error(`Refusing to handle cascading run in ${checkRunOwner}/${checkRunRepo}`)
             }
 
-            return await triggerGitArtifactsRuns(context, checkRunOwner, checkRunRepo, checkRun)
+            const comment = await triggerGitArtifactsRuns(context, checkRunOwner, checkRunRepo, checkRun)
+
+            const token = await getToken(context, checkRunOwner, checkRunRepo)
+            const { getGitArtifactsCommentID, appendToIssueComment } = require('./issues')
+            const gitArtifactsCommentID = await getGitArtifactsCommentID(context, token, checkRunOwner, checkRunRepo, req.body.check_run.head_sha)
+
+            if (gitArtifactsCommentID) {
+                await appendToIssueComment(context, token, checkRunOwner, checkRunRepo, gitArtifactsCommentID, comment)
+            }
+
+            return comment
         }
         return `Not a cascading run: ${name}; Doing nothing.`
     }

__tests__/index.test.js

@@ -127,6 +127,27 @@ let mockGitHubApiRequest = jest.fn((_context, _token, method, requestPath, paylo
     if (method === 'GET' && requestPath.endsWith('/pulls/4323')) return {
         head: { sha: 'dee501d15' }
     }
+    if (method === 'GET' && requestPath === '/search/issues?q=repo:git-for-windows/git+c8edb521bdabec14b07e9142e48cab77a40ba339+type:pr+%22git-artifacts%22') return {
+        items: [{
+            text_matches: [{
+                object_url: 'https://api.github.com/repositories/23216272/issues/comments/1450703020',
+                fragment: '/git-artifacts\n\nThe tag-git workflow run was started\n'
+            }]
+        }]
+    }
+    if (method === 'GET' && requestPath === '/repos/git-for-windows/git/issues/comments/1450703020') return {
+        body: '/git-artifacts\n\nThe tag-git workflow run [was started](https://url-to-tag-git/)'
+    }
+    if (method === 'PATCH' && requestPath === '/repos/git-for-windows/git/issues/comments/1450703020') {
+        expect(payload.body).toEqual(`/git-artifacts
+
+The tag-git workflow run [was started](https://url-to-tag-git/)
+
+git-artifacts-x86_64 run already exists at <url-to-existing-x86_64-run>.
+The \`git-artifacts-i686\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
+`)
+        return { html_url: 'https://github.com/git-for-windows/git/pull/4322#issuecomment-1450703020' }
+    }
     throw new Error(`Unhandled ${method}-${requestPath}-${JSON.stringify(payload)}`)
 })
 jest.mock('../GitForWindowsHelper/github-api-request', () => {