Skip to content

Commit 652a357

Browse files
authored
Merge pull request #136 from rimrul/drop-selfhosted-runners
drop support for selfhosted runners
2 parents 854e305 + 2fb05f2 commit 652a357

File tree

3 files changed

+0
-100
lines changed

3 files changed

+0
-100
lines changed

GitForWindowsHelper/index.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,6 @@ module.exports = async function (context, req) {
3636
return withStatus(500, undefined, e.message || JSON.stringify(e, null, 2))
3737
}
3838

39-
try {
40-
const selfHostedARM64Runners = require('./self-hosted-arm64-runners')
41-
if (req.headers['x-github-event'] === 'workflow_job'
42-
&& ['git-for-windows/git-for-windows-automation', 'git-for-windows/git-sdk-arm64'].includes(req.body.repository.full_name)
43-
&& ['queued', 'completed'].includes(req.body.action)
44-
&& req.body.workflow_job.labels.length === 2
45-
&& req.body.workflow_job.labels[0] === 'Windows'
46-
&& req.body.workflow_job.labels[1] === 'ARM64') return ok(await selfHostedARM64Runners(context, req))
47-
} catch (e) {
48-
context.log(e)
49-
return withStatus(500, undefined, e.message || JSON.stringify(e, null, 2))
50-
}
51-
5239
try {
5340
const finalizeGitForWindowsRelease = require('./finalize-g4w-release')
5441
if (req.headers['x-github-event'] === 'workflow_run'

GitForWindowsHelper/self-hosted-arm64-runners.js

Lines changed: 0 additions & 79 deletions
This file was deleted.

README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,6 @@ For convenience, the command can be abbreviated as `/add relnote <type> <message
6363

6464
**What does it do?** Call this command after a `/git-artifacts` command successfully produced the artifacts _and_ after the installer artifact has been validated manually, using [the "pre-flight checklist"](https://github.com/git-for-windows/build-extra/blob/HEAD/installer/checklist.txt). This will start [the `release-git` workflow](https://github.com/git-for-windows/git-for-windows-automation/actions/workflows/release-git.yml) to publish the artifacts in a new GitHub Release.
6565

66-
## Spinning up Windows/ARM64 runners
67-
68-
As GitHub Actions do not offer hosted Windows/ARM64 runners, Git for Windows needs to use self-hosted Windows/ARM64 runners to build the `clang-aarch64` versions of its MINGW packages.
69-
70-
To this end, the GitForWindowsHelper App notices when a job was queued [in the `git-for-windows-automation` repository](https://github.com/git-for-windows/git-for-windows-automation/actions/) that requires a Windows/ARM64 runner, and starts [the GitHub workflow to spin up an Azure VM with such a runner](https://github.com/git-for-windows/git-for-windows-automation/actions/workflows/create-azure-self-hosted-runners.yml). This VM is created from scratch and its runner is marked as ephemeral (meaning: it will run exactly one job for security reasons). Once the job is finished, the GitForWindowsHelper App starts [the GitHub workflow](https://github.com/git-for-windows/git-for-windows-automation/actions/workflows/delete-self-hosted-runner.yml) to decommission the VM.
71-
72-
The GitForWindowsHelper App will also notice when jobs are queued for PRs originating in forks, and immediately cancel them. This helps with keeping the cost of self-hosting these Windows/ARM64 at reasonable levels.
73-
7466
## Tips & Tricks for developing this GitHub App
7567

7668
### Debug/test-run as much Javascript via the command-line as possible

0 commit comments

Comments
 (0)