guessReleaseNotes: be smarter when looking at PRs

The default for PRs is to say "This closes <url>" when the `open-pr`
workflow creates a PR, referencing the original issue.

So it would not really help if we linked to that issue in the release
notes as much as if we looked for a URL in that referenced issue.

Therefore, let's follow that link and look for such a better URL.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/component-updates.js

@@ -50,7 +50,7 @@ const needsSeparateARM64Build = package_name => {
     ].includes(package_name)
 }
 
-const guessReleaseNotes = (issue) => {
+const guessReleaseNotes = async (context, issue) => {
     if (!issue.pull_request
         &&issue.labels.filter(label => label.name === 'component-update').length !== 1) throw new Error(`Cannot determine release note from issue ${issue.number}`)
     let { package_name, version } = guessComponentUpdateDetails(issue.title, issue.body)
@@ -69,6 +69,18 @@ const guessReleaseNotes = (issue) => {
 
         const match = issue.body.match(/See (https:\/\/\S+) for details/)
         if (match) return match[1]
+
+        const issueMatch = issue.body.match(/https:\/\/github\.com\/git-for-windows\/git\/issues\/(\d+)/)
+        if (issueMatch) {
+            const githubApiRequest = require('./github-api-request')
+            const issue = await githubApiRequest(
+                context,
+                null,
+                'GET',
+                `/repos/git-for-windows/git/issues/${issueMatch[1]}`
+            )
+            return matchURLInIssue(issue)
+        }
     }
 
     const url = await matchURL()

GitForWindowsHelper/slash-commands.js

@@ -311,7 +311,7 @@ module.exports = async (context, req) => {
             let [ , , , type, message ] = relNotesMatch
             if (!type) {
                 const { guessReleaseNotes } = require('./component-updates');
-                ({ type, message } = await guessReleaseNotes(req.body.issue))
+                ({ type, message } = await guessReleaseNotes(context, req.body.issue))
             }
 
             await thumbsUp()

test-guess-relnote.js

@@ -16,6 +16,6 @@
     )
 
     const { guessReleaseNotes } = require('./GitForWindowsHelper/component-updates')
-    const guessed = await guessReleaseNotes(issue)
+    const guessed = await guessReleaseNotes(console, issue)
     console.log(JSON.stringify(guessed, null, 2))
 })().catch(console.log)