Skip to content

Commit 75ce941

Browse files
committed
guess details better for GPG updates
Our current guessing is so bad that /open pr fails with > ERROR: PKGBUILD not found or is not a file this is because we guess the package name "gpg" when we need "gnupg" instead. Additionally, the version number we guess is prefixed with "gnupg-" which is undesirable. Update our heuristic to produce usefull details for GPG updates. Signed-off-by: Matthias Aßhauer <mha1993@live.de>
1 parent 268e3f5 commit 75ce941

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

GitForWindowsHelper/component-updates.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ const guessComponentUpdateDetails = (title, body) => {
99
if (['git-lfs'].includes(package_name)) package_name = `mingw-w64-${package_name}`
1010
else if (['git-credential-manager', 'gcm-core', 'gcm'].includes(package_name)) package_name = 'mingw-w64-git-credential-manager'
1111
else if (package_name === 'cygwin') package_name = 'msys2-runtime'
12+
else if (package_name === 'gpg') package_name = 'gnupg'
1213

1314
version = version
14-
.replace(/^(GCM |openssl-|OpenSSL_|v|V_|GnuTLS |tig-|Heimdal |cygwin-|PCRE2-|Bash-|curl-)/, '')
15+
.replace(/^(GCM |openssl-|OpenSSL_|v|V_|GnuTLS |tig-|Heimdal |cygwin-|PCRE2-|Bash-|curl-|gnupg-)/, '')
1516
.replace(/\s+patch\s+/, '.')
1617
.replace(/_/g, '.')
1718
.replace(/-release$/, '')

__tests__/component-updates.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ test('guessComponentUpdateDetails()', () => {
3636
['[New git-lfs version] v3.3.0', 'mingw-w64-git-lfs', '3.3.0'],
3737
['[New heimdal version] Heimdal 7.7.1 - Security Fix Release', 'heimdal', '7.7.1'],
3838
['[New gnutls version] GnuTLS 3.8.0', 'gnutls', '3.8.0'],
39-
['[New git-credential-manager version] GCM 2.0.886', 'mingw-w64-git-credential-manager', '2.0.886']
39+
['[New git-credential-manager version] GCM 2.0.886', 'mingw-w64-git-credential-manager', '2.0.886'],
40+
['[New gpg version] gnupg-2.2.42', 'gnupg', '2.2.42']
4041
]
4142
for (const [title, package_name, version] of titles) {
4243
expect(guessComponentUpdateDetails(title)).toEqual({ package_name, version })

0 commit comments

Comments
 (0)