getMissingDeployments(): fix msys-runtime assumptions

We no longer deploy `msys2-runtime` for i686 (because it is no longer
supported by Cygwin).

Instead, we deploy `msys2-runtime-3.3` for i686 (but not for x86_64).

Let's teach GitForWindowsHelper about these subtleties.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/component-updates.js

@@ -121,6 +121,8 @@ const getMissingDeployments = async (package_name, version) => {
     // MinTTY is at epoch 1, which is part of Pacman's versioning scheme
     if (package_name === 'mintty') version = `1~${version}`
     const architectures = ['i686', 'x86_64']
+    if (package_name === 'msys2-runtime') architectures.shift()
+    else if (package_name === 'msys2-runtime-3.3') architectures.pop()
 
     const urls = []
     const msysName = package_name.replace(/^mingw-w64-/, '')

__tests__/component-updates.test.js

@@ -132,11 +132,17 @@ http://www.gnutls.org/news.html#2023-02-10`
 test('getMissingDeployments()', async () => {
     const missingURL = 'https://wingit.blob.core.windows.net/x86-64/curl-8.1.2-1-x86_64.pkg.tar.xz'
     const missingMinTTYURL = 'https://wingit.blob.core.windows.net/i686/mintty-1~3.6.5-1-i686.pkg.tar.xz'
-    const mockDoesURLReturn404 = jest.fn(url => url === missingURL || url === missingMinTTYURL)
+    const bogus32BitMSYS2RuntimeURL = 'https://wingit.blob.core.windows.net/i686/msys2-runtime-3.4.9-1-i686.pkg.tar.xz'
+    const bogus64BitMSYS2RuntimeURL = 'https://wingit.blob.core.windows.net/x86-64/msys2-runtime-3.3-3.3.7-1-x86_64.pkg.tar.xz'
+    const mockDoesURLReturn404 = jest.fn(url => [
+        missingURL, missingMinTTYURL, bogus32BitMSYS2RuntimeURL, bogus64BitMSYS2RuntimeURL
+    ].includes(url))
     jest.mock('../GitForWindowsHelper/https-request', () => {
         return { doesURLReturn404: mockDoesURLReturn404 }
     })
 
     expect(await getMissingDeployments('curl', '8.1.2')).toEqual([missingURL])
     expect(await getMissingDeployments('mintty', '3.6.5')).toEqual([missingMinTTYURL])
+    expect(await getMissingDeployments('msys2-runtime', '3.4.9')).toEqual([])
+    expect(await getMissingDeployments('msys2-runtime-3.3', '3.3.7')).toEqual([])
 })