Skip to content

Commit 9c3b9c8

Browse files
committed
guess release notes: handle newer GCM tickets better
We really want that `mingw-w64-` prefix to avoid building _MSYS_ packages for Git Credential Manager. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 2085119 commit 9c3b9c8

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

GitForWindowsHelper/component-updates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const guessComponentUpdateDetails = (title, body) => {
77
if (!package_name || !version) throw new Error(`Could not guess component-update details from title '${title}'`)
88

99
if (['git-lfs'].includes(package_name)) package_name = `mingw-w64-${package_name}`
10-
else if (['gcm-core', 'gcm'].includes(package_name)) package_name = 'mingw-w64-git-credential-manager'
10+
else if (['git-credential-manager', 'gcm-core', 'gcm'].includes(package_name)) package_name = 'mingw-w64-git-credential-manager'
1111
else if (package_name === 'cygwin') package_name = 'msys2-runtime'
1212

1313
version = version

__tests__/component-updates.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ test('guessComponentUpdateDetails()', () => {
3333
['[New pcre2 version] PCRE2-10.42', 'pcre2', '10.42'],
3434
['[New git-lfs version] v3.3.0', 'mingw-w64-git-lfs', '3.3.0'],
3535
['[New heimdal version] Heimdal 7.7.1 - Security Fix Release', 'heimdal', '7.7.1'],
36-
['[New gnutls version] GnuTLS 3.8.0', 'gnutls', '3.8.0']
36+
['[New gnutls version] GnuTLS 3.8.0', 'gnutls', '3.8.0'],
37+
['[New git-credential-manager version] GCM 2.0.886', 'mingw-w64-git-credential-manager', '2.0.886']
3738
]
3839
for (const [title, package_name, version] of titles) {
3940
expect(guessComponentUpdateDetails(title)).toEqual({ package_name, version })

0 commit comments

Comments
 (0)