/deploy: trigger clang-aarch64 builds when appropriate

Since we now have support to automatically spin up/tear down
Windows/ARM64 runners as needed, we will want to make use of that by
deploying not only the i686/x86_64 MINGW packages, but by deploying the
aarch64 packages, too.

Note that the `git-credential-manager`, `git-lfs` and `wintoast`
packages are special: Git for Windows does not actually build the ARM64
variants of these packages via clang, but instead either downloads the
artifacts from the respective upstream projects or builds using Visual
Studio (which supports cross-compiling on hosted agents, in contrast to
MSYS2's clang). Therefore, these packages do _not_ require a separate
workflow run for ARM64.

An alternative to special-casing these packages in the
GitForWindowsHelper GitHub App would have been to turn the
`build-and-deploy` workflow into a dynamic matrix that spins up a
separate job for the `aarch64` architecture if, and when, needed.
However, that would have made that workflow even more complex than it
already is, and therefore that alternative was rejected.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/component-updates.js

@@ -41,6 +41,15 @@ const isMSYSPackage = package_name => {
         && !package_name.startsWith('mingw-w64-')
 }
 
+const needsSeparateARM64Build = package_name => {
+    if (package_name === 'git-extra') return true
+    return package_name.startsWith('mingw-w64-') && ![
+        'mingw-w64-git-credential-manager',
+        'mingw-w64-git-lfs',
+        'mingw-w64-wintoast'
+    ].includes(package_name)
+}
+
 const guessReleaseNotes = (issue) => {
     if (!issue.pull_request
         &&issue.labels.filter(label => label.name === 'component-update').length !== 1) throw new Error(`Cannot determine release note from issue ${issue.number}`)
@@ -62,5 +71,6 @@ module.exports = {
     guessComponentUpdateDetails,
     guessReleaseNotes,
     prettyPackageName,
-    isMSYSPackage
+    isMSYSPackage,
+    needsSeparateARM64Build
 }

GitForWindowsHelper/slash-commands.js

@@ -115,7 +115,7 @@ module.exports = async (context, req) => {
 
             await checkPermissions()
 
-            const { guessComponentUpdateDetails, isMSYSPackage } = require('./component-updates')
+            const { guessComponentUpdateDetails, isMSYSPackage, needsSeparateARM64Build } = require('./component-updates')
             const { package_name } = deployMatch[2]
                 ? { package_name: deployMatch[2] }
                 : guessComponentUpdateDetails(req.body.issue.title, req.body.issue.body)
@@ -162,6 +162,30 @@ module.exports = async (context, req) => {
                     text
                 )
             if (!isMSYSPackage(package_name)) {
+                let aarch64Answer
+                if (needsSeparateARM64Build(package_name)) {
+                    const aarch64Id = await queueCheckRun(
+                        context,
+                        await getToken(),
+                        'git-for-windows',
+                        repo,
+                        ref,
+                        'deploy_aarch64',
+                        `Build and deploy ${package_name}`,
+                        `Deploying ${package_name}`
+                    )
+                    aarch64Answer = await triggerBuild('aarch64')
+                    await updateCheckRun(
+                        context,
+                        await getToken(),
+                        'git-for-windows',
+                        repo,
+                        aarch64Id, {
+                            details_url: aarch64Answer.html_url
+                        }
+                    )
+                }
+
                 const id = await queueCheckRun(
                     context,
                     await getToken(),
@@ -174,7 +198,10 @@ module.exports = async (context, req) => {
                 )
 
                 const answer = await triggerBuild()
-                const answer2 = await appendToComment(`The workflow run [was started](${answer.html_url})`)
+                const answer2 = await appendToComment(aarch64Answer
+                    ? `The [i686/x86_64](${answer.html_url}) and the [amd64](${aarch64Answer.html_url}) workflow runs were started.`
+                    : `The workflow run [was started](${answer.html_url}).`
+                )
                 await updateCheckRun(
                     context,
                     await getToken(),