guessReleaseNotes(msys2-runtime): look harder for Cygwin's release notes

dscho · dscho · commit d622e0db8d3a · 2023-09-08T17:43:33.000+02:00
Cygwin's release notes link on their home page is sometimes not updated immediately after a new version has been made available. In the past, i.e. before Git for Windows built and deployed MSYS2 runtime versions via GitHub Actions, there was a fall-back to look for that link directly in the mailing list archives. In the meantime, Cygwin offers access to their mailing list archive via a public-inbox system, which makes the search even nicer. So let's do this, add a fall-back to look for the release notes directly on the mailing list. This corresponds to the code at https://github.com/git-for-windows/build-extra/blob/356779ddb189/please.sh#L1731-L1735 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
diff --git a/GitForWindowsHelper/component-updates.js b/GitForWindowsHelper/component-updates.js
@@ -61,6 +61,13 @@ const guessCygwinReleaseNotesURL = async (version) => {
     const match = html.match(new RegExp(`The most recent version of the Cygwin DLL is[^]*?<a href=['"]?([^"' ]*)[^>]*>${version}</a>`))
     if (match) return match[1]
 
+    // Sometimes Cygwin updates the home page a bit later than we'd want, let's
+    // find the announcement on the mailing list directly in that case:
+    const inboxPrefix = 'https://inbox.sourceware.org/cygwin-announce/'
+    const search = await fetchHTML(`${inboxPrefix}?q=cygwin-${version}`)
+    const searchMatch = search.match(new RegExp(`<a\\b(?:[^>]*)\\shref=['"]?([^'" ]+)[^>]*>cygwin ${version}-1</a>`))
+    if (searchMatch) return `${inboxPrefix}${searchMatch[1]}`
+
     throw new Error(`Could not determine Cygwin Release Notes URL for version ${version}`)
 }
 
diff --git a/__tests__/component-updates.test.js b/__tests__/component-updates.test.js
@@ -69,7 +69,17 @@ const mockFetchHTML = {
     The Cygwin DLL currently works with all recent, commercially released
     x86_64 versions of Windows, starting with Windows 7.
 </p>
-</div>`
+</div>`,
+    'https://inbox.sourceware.org/cygwin-announce/?q=cygwin-3.4.7': `<html><head><title>cygwin-3.4.7 - search results</title>[... plenty of stuff...]
+<pre>1. <b><a
+href="875y7c63s1.fsf@Rainer.invalid/">Re-Released: tar-1.34-2</a></b>
+    - by ASSI @ 2023-06-24 19:47 UTC [4%]
+
+2. <b><a
+href="20230616162552.879387-1-corinna-cygwin@cygwin.com/">cygwin 3.4.7-1</a></b>
+    - by Corinna Vinschen @ 2023-06-16 14:25 UTC [14%]
+
+</pre>[... even more stuff...]</body></html>`
 }
 const missingURL = 'https://wingit.blob.core.windows.net/x86-64/curl-8.1.2-1-x86_64.pkg.tar.xz'
 const missingMinTTYURL = 'https://wingit.blob.core.windows.net/i686/mintty-1~3.6.5-1-i686.pkg.tar.xz'
@@ -168,6 +178,17 @@ http://www.gnutls.org/news.html#2023-02-10`
         package: 'msys2-runtime',
         version: '3.4.9'
     })
+
+    expect(await guessReleaseNotes(context, {
+        labels: [{ name: 'component-update' }],
+        title: '[New cygwin version] cygwin-3.4.7',
+        body: `\nCygwin 3.4.7 release\n\nhttps://github.com/cygwin/cygwin/releases/tag/cygwin-3.4.7`
+    })).toEqual({
+        type: 'feature',
+        message: 'Comes with the MSYS2 runtime (Git for Windows flavor) based on [Cygwin v3.4.7](https://inbox.sourceware.org/cygwin-announce/20230616162552.879387-1-corinna-cygwin@cygwin.com/).',
+        package: 'msys2-runtime',
+        version: '3.4.7'
+    })
 })
 
 test('getMissingDeployments()', async () => {
