Teach /release to trigger the release-git workflow

This concludes the transition of Git for Windows' release process off of
Azure Pipelines onto GitHub workflows.

The added code is a bit more verbose than the previous one because we
have to do all the hard work of maintaining the Check Run in the
git-for-windows/git PR manually.

This is actually a net improvement over the previous situation, where
there was _no_ update in that PR whatsoever as to the current state of
the release.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/slash-commands.js

@@ -308,12 +308,101 @@ module.exports = async (context, req) => {
             await checkPermissions()
             await thumbsUp()
 
-            const { releaseGitArtifacts } = require('./azure-pipelines')
-            const answer = await releaseGitArtifacts(context, req.body.issue.number)
+            // Find the `git-artifacts` runs' IDs
+            const { getPRCommitSHA } = require('./issues')
+            const commitSHA = await getPRCommitSHA(context, await getToken(), owner, repo, issueNumber)
 
-            const { appendToIssueComment } = require('./issues')
-            const answer2 = await appendToIssueComment(context, await getToken(), owner, repo, commentId, `The Azure Release Pipeline run [was started](${answer.url})`)
-            return `I edited the comment: ${answer2.html_url}`
+            const { listCheckRunsForCommit, queueCheckRun, updateCheckRun } = require('./check-runs')
+            const releaseCheckRunId = await queueCheckRun(
+                context,
+                await getToken(),
+                'git-for-windows',
+                repo,
+                commitSHA,
+                'github-release',
+                `Publish Git for Windows @${commitSHA}`,
+                `Downloading the Git artifacts from the 'git-artifacts' runs and publishing them as a new GitHub Release at ${owner}/${repo}`
+            )
+
+            try {
+                let gitVersion
+                let tagGitWorkflowRunID
+                const workFlowRunIDs = {}
+                for (const architecture of ['x86_64', 'i686']) {
+                    const workflowName = `git-artifacts-${architecture}`
+                    const runs = await listCheckRunsForCommit(
+                        context,
+                        await getToken(owner, repo),
+                        owner,
+                        repo,
+                        commitSHA,
+                        workflowName
+                    )
+                    const latest = runs
+                        .filter(run => run.output.summary.indexOf(` from commit ${commitSHA} ` > 0))
+                        .sort((a, b) => a.id - b.id)
+                        .pop()
+                    if (latest) {
+                        if (latest.status !== 'completed' || latest.conclusion !== 'success') {
+                            throw new Error(`The '${workflowName}}' run at ${latest.html_url} did not succeed.`)
+                        }
+                        workFlowRunIDs[architecture] = latest.id
+                        const gitVersionMatch = latest.output.summary.match(/^Build Git (\S+) artifacts from commit (\S+) \(tag-git run #(\d+)\)$/)
+                        if (!gitVersionMatch) throw new Error(`Could not parse summary '${latest.output.summary}' of run ${latest.id}`)
+                        if (!gitVersion) gitVersion = gitVersionMatch[1]
+                        else if (gitVersion !== gitVersionMatch[1]) throw new Error(`The 'git-artifacts' runs disagree on the Git version`)
+                        if (!tagGitWorkflowRunID) tagGitWorkflowRunID = gitVersionMatch[3]
+                        else if (tagGitWorkflowRunID !== gitVersionMatch[3]) throw new Error(`The 'git-artifacts' runs are based on different 'tag-git' runs`)
+                    } else {
+                        throw new Error(`The '${workflowName}' run was not found`)
+                    }
+                }
+
+                await updateCheckRun(
+                    context,
+                    await getToken(),
+                    owner,
+                    repo,
+                    releaseCheckRunId, {
+                        output: {
+                            title: `Publish ${gitVersion} for @${commitSHA}`,
+                            summary: `Downloading the Git artifacts from ${workFlowRunIDs['x86_64']} and ${workFlowRunIDs['i686']} and publishing them as a new GitHub Release at ${owner}/${repo}`
+                        }
+                    }
+                )
+
+                const triggerWorkflowDispatch = require('./trigger-workflow-dispatch')
+                const answer = await triggerWorkflowDispatch(
+                    context,
+                    await getToken(),
+                    'git-for-windows',
+                    'git-for-windows-automation',
+                    'release-git.yml',
+                    'main', {
+                        git_artifacts_x86_64_workflow_run_id: workFlowRunIDs['x86_64'],
+                        git_artifacts_i686_workflow_run_id: workFlowRunIDs['i686']
+                    }
+                )
+
+                const { appendToIssueComment } = require('./issues')
+                const answer2 = await appendToIssueComment(context, await getToken(), owner, repo, commentId, `The \`release-git\` workflow run [was started](${answer.html_url})`)
+                return `I edited the comment: ${answer2.html_url}`
+            } catch (e) {
+                await updateCheckRun(
+                    context,
+                    await getToken(),
+                    owner,
+                    repo,
+                    releaseCheckRunId, {
+                        status: 'completed',
+                        conclusion: 'failure',
+                        output: {
+                            text: e.toString()
+                        }
+                    }
+                )
+                throw e
+            }
         }
 
         const relNotesMatch = command.match(/^\/add (relnote|release ?note)(\s+(blurb|feature|bug)\s+([^]*))?$/i)

__tests__/index.test.js

@@ -106,6 +106,9 @@ let mockGitHubApiRequest = jest.fn((_context, _token, method, requestPath, paylo
     if (method === 'GET' && requestPath.endsWith('/pulls/4322')) return {
         head: { sha: 'c8edb521bdabec14b07e9142e48cab77a40ba339' }
     }
+    if (method === 'GET' && requestPath.endsWith('/pulls/4328')) return {
+        head: { sha: 'this-will-be-rc2' }
+    }
     throw new Error(`Unhandled ${method}-${requestPath}-${JSON.stringify(payload)}`)
 })
 jest.mock('../GitForWindowsHelper/github-api-request', () => {
@@ -262,7 +265,15 @@ The MINGW workflow run [was started](dispatched-workflow-open-pr.yml)`
 
 let mockQueueCheckRun = jest.fn(() => 'check-run-id')
 let mockUpdateCheckRun = jest.fn()
-let mockListCheckRunsForCommit = jest.fn((_context, _token, _owner, _repo, _rev, checkRunName) => {
+let mockListCheckRunsForCommit = jest.fn((_context, _token, _owner, _repo, rev, checkRunName) => {
+    if (rev === 'this-will-be-rc2') {
+        const output = {
+            title: 'Build Git -rc2 artifacts',
+            summary: 'Build Git -rc2 artifacts from commit this-will-be-rc2 (tag-git run #987)'
+        }
+        if (checkRunName === 'git-artifacts-x86_64') return [{ id: 8664, status: 'completed', conclusion: 'success', output }]
+        if (checkRunName === 'git-artifacts-i686') return [{ id: 686, status: 'completed', conclusion: 'success', output }]
+    }
     if (checkRunName === 'git-artifacts-x86_64') return [{
         status: 'completed',
         conclusion: 'success',
@@ -422,3 +433,30 @@ The \`tag-git\` workflow run [was started](dispatched-workflow-tag-git.yml)`,
         snapshot: false
     })
 })
+
+testIssueComment('/release', {
+    issue: {
+        number: 4328,
+        title: 'Rebase to v2.40.0-rc2',
+        pull_request: {
+            html_url: 'https://github.com/git-for-windows/git/pull/4328'
+        }
+    }
+}, async (context) => {
+    expect(await index(context, context.req)).toBeUndefined()
+    expect(context.res).toEqual({
+        body: `I edited the comment: appended-comment-body-existing comment body
+
+The \`release-git\` workflow run [was started](dispatched-workflow-release-git.yml)`,
+        headers: undefined,
+        status: undefined
+    })
+    expect(mockGetInstallationAccessToken).toHaveBeenCalledTimes(1)
+    expect(mockGitHubApiRequestAsApp).not.toHaveBeenCalled()
+    expect(dispatchedWorkflows).toHaveLength(1)
+    expect(dispatchedWorkflows[0].html_url).toEqual('dispatched-workflow-release-git.yml')
+    expect(dispatchedWorkflows[0].payload.inputs).toEqual({
+        git_artifacts_x86_64_workflow_run_id: 8664,
+        git_artifacts_i686_workflow_run_id: 686
+    })
+})