/open pr: support running in git-for-windows/msys2-runtime

The MSYS2 runtime is a special thing indeed. Most of the time, patches
for Git for Windows' variant of this component come in not via MSYS2,
but via PRs in https://github.com/git-for-windows/msys2-runtime.

I already taught the `open-pr` GitHub workflow about this in
git-for-windows/git-for-windows-automation#87,
and now it is time to extend the `/open pr` slash command to cover this
scenario, too.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

GitForWindowsHelper/slash-commands.js

@@ -50,12 +50,18 @@ module.exports = async (context, req) => {
 
     try {
         if (command == '/open pr') {
-            if (owner !== 'git-for-windows' || repo !== 'git') return `Ignoring ${command} in unexpected repo: ${commentURL}`
+            if (owner !== 'git-for-windows' || !['git', 'msys2-runtime'].includes(repo)) return `Ignoring ${command} in unexpected repo: ${commentURL}`
 
             await checkPermissions()
 
             const { guessComponentUpdateDetails, packageNeedsBothMSYSAndMINGW } = require('./component-updates')
-            const { package_name, version } = guessComponentUpdateDetails(req.body.issue.title, req.body.issue.body)
+            const { getPRCommitSHA } = require('./issues')
+            const { package_name, version } = repo === 'msys2-runtime'
+                ? {
+                    package_name: repo,
+                    version: await getPRCommitSHA(context, await getToken(), owner, repo, issueNumber)
+                }
+                : guessComponentUpdateDetails(req.body.issue.title, req.body.issue.body)
 
             await thumbsUp()
 

__tests__/index.test.js

@@ -136,6 +136,9 @@ let mockGitHubApiRequest = jest.fn((_context, _token, method, requestPath, paylo
     if (method === 'GET' && requestPath.endsWith('/pulls/765')) return {
         head: { sha: 'c0ffee1ab7e' }
     }
+    if (method === 'GET' && requestPath.endsWith('/pulls/69')) return {
+        head: { sha: '59d71150a6ee93ab954221c43ca86f8eafe68ddc'}
+    }
     if (method === 'PATCH' && requestPath.endsWith('/git/refs/heads/main')) {
         if (payload.sha !== 'c0ffee1ab7e') throw new Error(`Unexpected sha: ${payload.sha}`)
         if (payload.force !== false) throw new Error(`Unexpected force value: ${payload.force}`)
@@ -330,6 +333,44 @@ The MINGW workflow run [was started](dispatched-workflow-open-pr.yml)`
     })
 })
 
+testIssueComment('/open pr', {
+    repository: {
+        name: 'msys2-runtime'
+    },
+    issue: {
+        number: 69,
+        title: 'Support OneDrive better',
+        body: `This backports patches that avoid hydrating files on OneDrive _just_ to \`stat()\` them.
+
+See also https://github.com/msys2/msys2-runtime/issues/206.`,
+        pull_request: {
+            html_url: 'https://github.com/git-for-windows/msys2-runtime/pull/69'
+        }
+    }
+}, async (context) => {
+    expect(await index(context, context.req)).toBeUndefined()
+    expect(context.res).toEqual({
+        body: `I edited the comment: appended-comment-body-existing comment body
+
+The workflow run [was started](dispatched-workflow-open-pr.yml)`,
+        headers: undefined,
+        status: undefined
+    })
+    expect(mockGetInstallationAccessToken).toHaveBeenCalledTimes(1)
+    expect(mockGitHubApiRequestAsApp).not.toHaveBeenCalled()
+    expect(dispatchedWorkflows).toHaveLength(1)
+    expect(dispatchedWorkflows[0].payload.inputs.package).toEqual('msys2-runtime')
+    expect(dispatchedWorkflows[0].payload.inputs.version).toEqual('59d71150a6ee93ab954221c43ca86f8eafe68ddc')
+    expect(mockGitHubApiRequest).toHaveBeenCalled()
+    const msysComment = mockGitHubApiRequest.mock.calls[mockGitHubApiRequest.mock.calls.length - 1]
+    expect(msysComment[3]).toEqual('/repos/git-for-windows/msys2-runtime/issues/comments/0')
+    expect(msysComment[4]).toEqual({
+        body: `existing comment body
+
+The workflow run [was started](dispatched-workflow-open-pr.yml)`
+    })
+})
+
 testIssueComment('/updpkgsums', {
     issue: {
         number: 104,