Skip to content

Commit 0e4f870

Browse files
fix: fix merge conflicts
1 parent 39d5239 commit 0e4f870

File tree

2 files changed

+24
-26
lines changed

2 files changed

+24
-26
lines changed

lambdas/functions/control-plane/src/scale-runners/scale-up.test.ts

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2053,7 +2053,6 @@ describe('scaleUp with Github Data Residency', () => {
20532053
});
20542054
});
20552055

2056-
<<<<<<< HEAD
20572056
describe('Retry mechanism tests', () => {
20582057
beforeEach(() => {
20592058
process.env.ENABLE_ORGANIZATION_RUNNERS = 'true';
@@ -2195,7 +2194,30 @@ describe('Retry mechanism tests', () => {
21952194
id: msg.id,
21962195
messageId: msg.messageId,
21972196
}),
2198-
=======
2197+
);
2198+
});
2199+
});
2200+
2201+
it('calls publishRetryMessage after runner creation', async () => {
2202+
const messages = createTestMessages(1);
2203+
mockCreateRunner.mockResolvedValue(['i-12345']); // Create the requested runner
2204+
2205+
const callOrder: string[] = [];
2206+
mockPublishRetryMessage.mockImplementation(() => {
2207+
callOrder.push('publishRetryMessage');
2208+
return Promise.resolve();
2209+
});
2210+
mockCreateRunner.mockImplementation(async () => {
2211+
callOrder.push('createRunner');
2212+
return ['i-12345'];
2213+
});
2214+
2215+
await scaleUpModule.scaleUp(messages);
2216+
2217+
expect(callOrder).toEqual(['createRunner', 'publishRetryMessage']);
2218+
});
2219+
});
2220+
21992221
describe('parseEc2OverrideConfig', () => {
22002222
describe('Basic Fleet Overrides', () => {
22012223
it('should parse instance-type label', () => {
@@ -2692,30 +2714,10 @@ describe('parseEc2OverrideConfig', () => {
26922714
);
26932715
expect(result?.InstanceRequirements?.BaselinePerformanceFactors?.Cpu?.References?.[1]?.InstanceFamily).toBe(
26942716
'amd',
2695-
>>>>>>> 44df86d7 (test: fix test cases)
26962717
);
26972718
});
26982719
});
26992720

2700-
<<<<<<< HEAD
2701-
it('calls publishRetryMessage after runner creation', async () => {
2702-
const messages = createTestMessages(1);
2703-
mockCreateRunner.mockResolvedValue(['i-12345']); // Create the requested runner
2704-
2705-
const callOrder: string[] = [];
2706-
mockPublishRetryMessage.mockImplementation(() => {
2707-
callOrder.push('publishRetryMessage');
2708-
return Promise.resolve();
2709-
});
2710-
mockCreateRunner.mockImplementation(async () => {
2711-
callOrder.push('createRunner');
2712-
return ['i-12345'];
2713-
});
2714-
2715-
await scaleUpModule.scaleUp(messages);
2716-
2717-
expect(callOrder).toEqual(['createRunner', 'publishRetryMessage']);
2718-
=======
27192721
describe('Edge Cases', () => {
27202722
it('should return undefined when empty array is provided', () => {
27212723
const result = scaleUpModule.parseEc2OverrideConfig([]);
@@ -2912,7 +2914,6 @@ describe('parseEc2OverrideConfig', () => {
29122914
expect(result?.InstanceRequirements?.SpotMaxPricePercentageOverLowestPrice).toBe(100);
29132915
expect(result?.InstanceRequirements?.OnDemandMaxPricePercentageOverLowestPrice).toBe(150);
29142916
});
2915-
>>>>>>> 44df86d7 (test: fix test cases)
29162917
});
29172918
});
29182919

lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ import { createGithubAppAuth, createGithubInstallationAuth, createOctokitClient
77
import { createRunner, listEC2Runners, tag } from './../aws/runners';
88
import { Ec2OverrideConfig, RunnerInputParameters } from './../aws/runners.d';
99
import { metricGitHubAppRateLimit } from '../github/rate-limit';
10-
<<<<<<< HEAD
1110
import { publishRetryMessage } from './job-retry';
12-
=======
1311
import {
1412
_InstanceType,
1513
Tenancy,
@@ -40,7 +38,6 @@ import {
4038
TotalLocalStorageGBRequest,
4139
BaselineEbsBandwidthMbpsRequest,
4240
} from '@aws-sdk/client-ec2';
43-
>>>>>>> 44df86d7 (test: fix test cases)
4441

4542
const logger = createChildLogger('scale-up');
4643

0 commit comments

Comments
 (0)