Skip to content

Commit 175b99c

Browse files
fix: fix merge conflicts
1 parent 04cbf46 commit 175b99c

File tree

2 files changed

+24
-26
lines changed

2 files changed

+24
-26
lines changed

lambdas/functions/control-plane/src/scale-runners/scale-up.test.ts

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2219,7 +2219,6 @@ describe('scaleUp with Github Data Residency', () => {
22192219
});
22202220
});
22212221

2222-
<<<<<<< HEAD
22232222
describe('Retry mechanism tests', () => {
22242223
beforeEach(() => {
22252224
process.env.ENABLE_ORGANIZATION_RUNNERS = 'true';
@@ -2361,7 +2360,30 @@ describe('Retry mechanism tests', () => {
23612360
id: msg.id,
23622361
messageId: msg.messageId,
23632362
}),
2364-
=======
2363+
);
2364+
});
2365+
});
2366+
2367+
it('calls publishRetryMessage after runner creation', async () => {
2368+
const messages = createTestMessages(1);
2369+
mockCreateRunner.mockResolvedValue(['i-12345']); // Create the requested runner
2370+
2371+
const callOrder: string[] = [];
2372+
mockPublishRetryMessage.mockImplementation(() => {
2373+
callOrder.push('publishRetryMessage');
2374+
return Promise.resolve();
2375+
});
2376+
mockCreateRunner.mockImplementation(async () => {
2377+
callOrder.push('createRunner');
2378+
return ['i-12345'];
2379+
});
2380+
2381+
await scaleUpModule.scaleUp(messages);
2382+
2383+
expect(callOrder).toEqual(['createRunner', 'publishRetryMessage']);
2384+
});
2385+
});
2386+
23652387
describe('parseEc2OverrideConfig', () => {
23662388
describe('Basic Fleet Overrides', () => {
23672389
it('should parse instance-type label', () => {
@@ -2858,30 +2880,10 @@ describe('parseEc2OverrideConfig', () => {
28582880
);
28592881
expect(result?.InstanceRequirements?.BaselinePerformanceFactors?.Cpu?.References?.[1]?.InstanceFamily).toBe(
28602882
'amd',
2861-
>>>>>>> 44df86d7 (test: fix test cases)
28622883
);
28632884
});
28642885
});
28652886

2866-
<<<<<<< HEAD
2867-
it('calls publishRetryMessage after runner creation', async () => {
2868-
const messages = createTestMessages(1);
2869-
mockCreateRunner.mockResolvedValue(['i-12345']); // Create the requested runner
2870-
2871-
const callOrder: string[] = [];
2872-
mockPublishRetryMessage.mockImplementation(() => {
2873-
callOrder.push('publishRetryMessage');
2874-
return Promise.resolve();
2875-
});
2876-
mockCreateRunner.mockImplementation(async () => {
2877-
callOrder.push('createRunner');
2878-
return ['i-12345'];
2879-
});
2880-
2881-
await scaleUpModule.scaleUp(messages);
2882-
2883-
expect(callOrder).toEqual(['createRunner', 'publishRetryMessage']);
2884-
=======
28852887
describe('Edge Cases', () => {
28862888
it('should return undefined when empty array is provided', () => {
28872889
const result = scaleUpModule.parseEc2OverrideConfig([]);
@@ -3078,7 +3080,6 @@ describe('parseEc2OverrideConfig', () => {
30783080
expect(result?.InstanceRequirements?.SpotMaxPricePercentageOverLowestPrice).toBe(100);
30793081
expect(result?.InstanceRequirements?.OnDemandMaxPricePercentageOverLowestPrice).toBe(150);
30803082
});
3081-
>>>>>>> 44df86d7 (test: fix test cases)
30823083
});
30833084
});
30843085

lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ import { createGithubAppAuth, createGithubInstallationAuth, createOctokitClient
77
import { createRunner, listEC2Runners, tag, terminateRunner } from './../aws/runners';
88
import { Ec2OverrideConfig, RunnerInputParameters } from './../aws/runners.d';
99
import { metricGitHubAppRateLimit } from '../github/rate-limit';
10-
<<<<<<< HEAD
1110
import { publishRetryMessage } from './job-retry';
12-
=======
1311
import {
1412
_InstanceType,
1513
Tenancy,
@@ -40,7 +38,6 @@ import {
4038
TotalLocalStorageGBRequest,
4139
BaselineEbsBandwidthMbpsRequest,
4240
} from '@aws-sdk/client-ec2';
43-
>>>>>>> 44df86d7 (test: fix test cases)
4441

4542
const logger = createChildLogger('scale-up');
4643

0 commit comments

Comments
 (0)