Skip to content

Commit 25c0704

Browse files
piotrjclaude
andcommitted
refactor(runners): pass allocationStrategy to generateFleetOverrides
Move the prioritized strategy check into generateFleetOverrides itself rather than having the caller decide what to pass, making the logic more explicit and self-contained. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 085756d commit 25c0704

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lambdas/functions/control-plane/src/aws/runners.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ function generateFleetOverrides(
127127
subnetIds: string[],
128128
instancesTypes: string[],
129129
amiId?: string,
130+
allocationStrategy?: string,
130131
instanceTypePriorities?: Record<string, number>,
131132
): FleetLaunchTemplateOverridesRequest[] {
132133
const result: FleetLaunchTemplateOverridesRequest[] = [];
@@ -136,7 +137,7 @@ function generateFleetOverrides(
136137
SubnetId: s,
137138
InstanceType: i as _InstanceType,
138139
ImageId: amiId,
139-
...(instanceTypePriorities !== undefined && { Priority: instanceTypePriorities[i] ?? index }),
140+
...(allocationStrategy === 'prioritized' && { Priority: instanceTypePriorities?.[i] ?? index }),
140141
};
141142
result.push(item);
142143
});
@@ -279,9 +280,8 @@ async function createInstances(
279280
runnerParameters.subnets,
280281
runnerParameters.ec2instanceCriteria.instanceTypes,
281282
amiIdOverride,
282-
runnerParameters.ec2instanceCriteria.instanceAllocationStrategy === 'prioritized'
283-
? (runnerParameters.ec2instanceCriteria.instanceTypePriorities ?? {})
284-
: undefined,
283+
runnerParameters.ec2instanceCriteria.instanceAllocationStrategy,
284+
runnerParameters.ec2instanceCriteria.instanceTypePriorities,
285285
),
286286
},
287287
],

0 commit comments

Comments
 (0)