Skip to content

Commit 2bb21df

Browse files
CopilotBrend-Smits
andauthored
fix: remove superficial auth throttle test per code review feedback
Agent-Logs-Url: https://github.com/github-aws-runners/terraform-aws-github-runner/sessions/1d1a46e4-807c-4c6e-864d-50a9c09dd84e Co-authored-by: Brend-Smits <15904543+Brend-Smits@users.noreply.github.com>
1 parent be1ad95 commit 2bb21df

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

lambdas/functions/control-plane/src/github/auth.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,6 @@ describe('Test createOctoClient', () => {
6363
expect(result.request.endpoint.DEFAULTS.mediaType.previews).toStrictEqual(['antiope']);
6464
});
6565

66-
it('Configures throttle handlers to return true for retry', async () => {
67-
const token = '123456';
68-
const result = await createOctokitClient(token);
69-
70-
// Access the internal throttle options via the Octokit instance
71-
// The onRateLimit and onSecondaryRateLimit should return true to enable retries
72-
const throttleOptions = (result as unknown as { throttleOptions: Record<string, unknown> }).throttleOptions;
73-
74-
// Since we can't directly access internal plugin options, verify the behavior
75-
// by checking that the client was created successfully with throttling plugin
76-
expect(result).toBeDefined();
77-
});
7866
});
7967

8068
describe('Test createGithubAppAuth', () => {

0 commit comments

Comments
 (0)