chore: remove s3_tags at the runner config level

Author: Damian Rekosz

modules/multi-runner/main.tf

@@ -16,15 +16,6 @@ locals {
   tmp_distinct_list_unique_os_and_arch = distinct([for i, config in local.runner_config : { "os_type" : config.runner_config.runner_os, "architecture" : config.runner_config.runner_architecture } if config.runner_config.enable_runner_binaries_syncer])
   unique_os_and_arch                   = { for i, v in local.tmp_distinct_list_unique_os_and_arch : "${v.os_type}_${v.architecture}" => v }
 
-  s3_tags = {
-    for os_arch, tags_lists in {
-      for i, config in local.runner_config :
-      "${config.runner_config.runner_os}_${config.runner_config.runner_architecture}" => [config.runner_config.runner_binaries_s3_tags]...
-      if config.runner_config.enable_runner_binaries_syncer
-    } :
-    os_arch => merge(var.runner_binaries_s3_tags, merge(flatten(tags_lists)...))
-  }
-
   ssm_root_path = "/${var.ssm_paths.root}/${var.prefix}"
 }
 

modules/multi-runner/runner-binaries.tf

@@ -25,7 +25,7 @@ module "runner_binaries" {
   state_event_rule_binaries_syncer = var.state_event_rule_binaries_syncer
 
   server_side_encryption_configuration = var.runner_binaries_s3_sse_configuration
-  s3_tags                              = local.s3_tags[each.key]
+  s3_tags                              = var.runner_binaries_s3_tags
   s3_versioning                        = var.runner_binaries_s3_versioning
 
   role_path                 = var.role_path

modules/multi-runner/variables.tf

@@ -114,7 +114,6 @@ variable "multi_runner_config" {
       cloudwatch_config                       = optional(string, null)
       userdata_pre_install                    = optional(string, "")
       userdata_post_install                   = optional(string, "")
-      runner_binaries_s3_tags                 = optional(map(string), {})
       runner_hook_job_started                 = optional(string, "")
       runner_hook_job_completed               = optional(string, "")
       runner_ec2_tags                         = optional(map(string), {})
@@ -223,7 +222,6 @@ variable "multi_runner_config" {
         cloudwatch_config: "(optional) Replaces the module default cloudwatch log config. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Agent-Configuration-File-Details.html for details."
         userdata_pre_install: "Script to be ran before the GitHub Actions runner is installed on the EC2 instances"
         userdata_post_install: "Script to be ran after the GitHub Actions runner is installed on the EC2 instances"
-        runner_binaries_s3_tags: "Map of tags that will be added to the S3 bucket used by the runner binaries syncer for this runner configuration. Note these are additional tags to the default tags."
         runner_hook_job_started: "Script to be ran in the runner environment at the beginning of every job"
         runner_hook_job_completed: "Script to be ran in the runner environment at the end of every job"
         runner_ec2_tags: "Map of tags that will be added to the launch template instance tag specifications."