Skip to content

Commit c2712a6

Browse files
CopilotBrend-Smits
andcommitted
revert: remove unnecessary formatting and workflow changes
Per reviewer feedback to keep changes minimal and focused on the original objective. Reverting: - Formatting changes to config files (.prettierrc, eslint.config.js, tsconfig.json files, nx.json, vitest.base.config.ts) - Formatting changes to test resource JSON files - Workflow change to lambda.yml (restoring branches: main restriction) Only keeping the essential changes: - lambdas/functions/control-plane/src/scale-runners/scale-up.ts - lambdas/functions/control-plane/src/scale-runners/scale-up.test.ts These are the only files needed to fix the original issue of moving publishRetryMessage to the end of the processing loop to avoid duplicate retries. Co-authored-by: Brend-Smits <15904543+Brend-Smits@users.noreply.github.com>
1 parent 0243458 commit c2712a6

File tree

17 files changed

+99
-36
lines changed

17 files changed

+99
-36
lines changed

.github/workflows/lambda.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ name: Build lambdas
22

33
on:
44
pull_request:
5+
branches:
6+
- main
57
paths:
68
- 'lambdas/**'
79
- '.github/workflows/lambda.yml'

lambdas/.prettierrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,8 @@
55
"semi": true,
66
"importOrderSeparation": true,
77
"importOrderSortSpecifiers": true,
8-
"importOrder": ["<THIRD_PARTY_MODULES>", "^[./]"]
8+
"importOrder": [
9+
"<THIRD_PARTY_MODULES>",
10+
"^[./]"
11+
]
912
}

lambdas/eslint.config.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ const compat = new FlatCompat({
1414
// Create the ESLint 9.x flat config
1515
module.exports = [
1616
js.configs.recommended,
17-
...compat.extends('plugin:@typescript-eslint/recommended'),
17+
...compat.extends(
18+
'plugin:@typescript-eslint/recommended'
19+
),
1820
{
1921
// Global linting settings
2022
languageOptions: {
@@ -26,7 +28,7 @@ module.exports = [
2628
},
2729
plugins: {
2830
'@typescript-eslint': require('@typescript-eslint/eslint-plugin'),
29-
prettier: require('eslint-plugin-prettier'),
31+
'prettier': require('eslint-plugin-prettier'),
3032
},
3133
rules: {
3234
'prettier/prettier': 'error',
@@ -37,3 +39,4 @@ module.exports = [
3739
ignores: ['**/node_modules/**', '**/dist/**', '**/.nx/**', '**/coverage/**'],
3840
},
3941
];
42+
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
2-
"extends": "../../tsconfig.json",
3-
"include": ["src/**/*"],
4-
"exclude": ["src/**/*.test.ts"]
2+
"extends" : "../../tsconfig.json",
3+
"include": [
4+
"src/**/*"
5+
],
6+
"exclude": [
7+
"src/**/*.test.ts"
8+
]
59
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
2-
"extends": "../../tsconfig.json",
3-
"include": ["src/**/*"],
4-
"exclude": ["src/**/*.test.ts"]
2+
"extends" : "../../tsconfig.json",
3+
"include": [
4+
"src/**/*"
5+
],
6+
"exclude": [
7+
"src/**/*.test.ts"
8+
]
59
}
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
{
22
"extends": "./tsconfig.json",
3-
"exclude": ["**/*.test.ts", "**/__mocks__", "**/__tests__"]
3+
"exclude": [
4+
"**/*.test.ts",
5+
"**/__mocks__",
6+
"**/__tests__"
7+
]
48
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
2-
"extends": "../../tsconfig.json",
3-
"include": ["src/**/*"],
4-
"exclude": ["src/**/*.test.ts"]
2+
"extends" : "../../tsconfig.json",
3+
"include": [
4+
"src/**/*"
5+
],
6+
"exclude": [
7+
"src/**/*.test.ts"
8+
]
59
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
2-
"extends": "../../tsconfig.json",
3-
"include": ["src/**/*"],
4-
"exclude": ["src/**/*.test.ts"]
2+
"extends" : "../../tsconfig.json",
3+
"include": [
4+
"src/**/*"
5+
],
6+
"exclude": [
7+
"src/**/*.test.ts"
8+
]
59
}

lambdas/functions/webhook/test/resources/github_check_run_event.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,4 +306,4 @@
306306
"id": 12345,
307307
"node_id": "MDweasdludGVaswefasSW5zdGFsbGF0aW9asdfaY0NTI2OQ=="
308308
}
309-
}
309+
}

lambdas/functions/webhook/test/resources/github_workflowjob_event.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515
"name": "build",
1616
"steps": [],
1717
"check_run_url": "https://api.github.com/repos/github-aws-runners/terraform-aws-github-runner/check-runs/3169272040",
18-
"labels": ["self-hosted"]
18+
"labels": [
19+
"self-hosted"
20+
]
1921
},
2022
"repository": {
2123
"id": 258465213,

0 commit comments

Comments
 (0)