Skip to content

Commit 5b785e2

Browse files
1 parent 77dd6d8 commit 5b785e2

2 files changed

Lines changed: 183 additions & 0 deletions

File tree

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
{
2+
"schema_version": "1.4.0",
3+
"id": "GHSA-94xm-jj8x-3cr4",
4+
"modified": "2026-03-25T21:10:05Z",
5+
"published": "2026-03-25T21:10:05Z",
6+
"aliases": [
7+
"CVE-2026-33668"
8+
],
9+
"summary": "Vikunja Allows Disabled/Locked User Accounts to Authenticate via API Tokens, CalDAV, and OpenID Connect",
10+
"details": "## Summary\n\nWhen a user account is disabled or locked, the status check is only enforced on the local login and JWT token refresh paths. Three other authentication paths — API tokens, CalDAV basic auth, and OpenID Connect — do not verify user status, allowing disabled or locked users to continue accessing the API and syncing data.\n\n## Details\n\nUser status (`StatusDisabled`, `StatusAccountLocked`) is checked in only two places:\n\n1. **Local/LDAP login** (`pkg/routes/api/v1/login.go:74`) — prevents issuing new JWTs\n2. **JWT token refresh** (`pkg/routes/api/v1/login.go:247`) — prevents refreshing expired JWTs\n\nThree other authentication paths fetch the user from the database via `GetUserByID` but never inspect the returned user's status:\n\n### 1. API Token Authentication (`pkg/routes/api_tokens.go:76-103`)\n\nAPI tokens are long-lived (up to years) and have no refresh cycle. A disabled user's API tokens remain fully functional until they expire naturally.\n\n### 2. CalDAV Basic Auth (`pkg/routes/caldav/auth.go`)\n\nThe CalDAV basic auth handler validates credentials but does not check user status before granting access. A disabled user with valid credentials or a CalDAV token can continue syncing calendars and tasks.\n\n### 3. OpenID Connect Callback (`pkg/modules/auth/openid/openid.go`)\n\nThe OIDC callback issues a fresh JWT token after validating the identity provider's response but does not check whether the Vikunja user account is disabled. If the user's identity provider session is still active, they receive a valid JWT despite being disabled in Vikunja.\n\n## Impact\n\nAn administrator who disables a user account expects that user to be immediately locked out. In practice:\n\n- **API tokens**: The user retains full API access for the remaining lifetime of any issued API tokens — potentially months or years.\n- **CalDAV**: The user can continue reading and writing tasks/events via any CalDAV client.\n- **OIDC**: The user can obtain a fresh, fully valid JWT by re-authenticating through their identity provider, completely bypassing the account disable.\n\n## Proof of Concept\n\n1. Create a user and generate an API token.\n2. Disable the user account via the admin API or CLI.\n3. Make an API request using the API token:\n ```bash\n curl -H \"Authorization: Bearer tk_<token>\" https://vikunja.example/api/v1/user\n ```\n4. The request succeeds with a 200 response despite the account being disabled.",
11+
"severity": [
12+
{
13+
"type": "CVSS_V4",
14+
"score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N"
15+
}
16+
],
17+
"affected": [
18+
{
19+
"package": {
20+
"ecosystem": "Go",
21+
"name": "code.vikunja.io/api"
22+
},
23+
"ranges": [
24+
{
25+
"type": "ECOSYSTEM",
26+
"events": [
27+
{
28+
"introduced": "0.18.0"
29+
},
30+
{
31+
"fixed": "2.2.1"
32+
}
33+
]
34+
}
35+
],
36+
"database_specific": {
37+
"last_known_affected_version_range": "<= 2.2.0"
38+
}
39+
}
40+
],
41+
"references": [
42+
{
43+
"type": "WEB",
44+
"url": "https://github.com/go-vikunja/vikunja/security/advisories/GHSA-94xm-jj8x-3cr4"
45+
},
46+
{
47+
"type": "ADVISORY",
48+
"url": "https://nvd.nist.gov/vuln/detail/CVE-2026-33668"
49+
},
50+
{
51+
"type": "WEB",
52+
"url": "https://github.com/go-vikunja/vikunja/commit/033922309f492996c928122fb49b691339199c35"
53+
},
54+
{
55+
"type": "WEB",
56+
"url": "https://github.com/go-vikunja/vikunja/commit/04704e0fde4b027039cf583110cee7afe136fc1b"
57+
},
58+
{
59+
"type": "WEB",
60+
"url": "https://github.com/go-vikunja/vikunja/commit/0b04768d830c80e9fde1b0962db1499cc652da0e"
61+
},
62+
{
63+
"type": "WEB",
64+
"url": "https://github.com/go-vikunja/vikunja/commit/fd452b9cb6457fd4f9936527a14c359818f1cca7"
65+
},
66+
{
67+
"type": "PACKAGE",
68+
"url": "https://github.com/go-vikunja/vikunja"
69+
},
70+
{
71+
"type": "WEB",
72+
"url": "https://vikunja.io/changelog/vikunja-v2.2.2-was-released"
73+
}
74+
],
75+
"database_specific": {
76+
"cwe_ids": [
77+
"CWE-285"
78+
],
79+
"severity": "HIGH",
80+
"github_reviewed": true,
81+
"github_reviewed_at": "2026-03-25T21:10:05Z",
82+
"nvd_published_at": "2026-03-24T16:16:34Z"
83+
}
84+
}
Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
{
2+
"schema_version": "1.4.0",
3+
"id": "GHSA-c2c7-rcm5-vvqj",
4+
"modified": "2026-03-25T21:12:07Z",
5+
"published": "2026-03-25T21:12:07Z",
6+
"aliases": [
7+
"CVE-2026-33671"
8+
],
9+
"summary": "Picomatch has a ReDoS vulnerability via extglob quantifiers",
10+
"details": "### Impact\n`picomatch` is vulnerable to Regular Expression Denial of Service (ReDoS) when processing crafted extglob patterns. Certain patterns using extglob quantifiers such as `+()` and `*()`, especially when combined with overlapping alternatives or nested extglobs, are compiled into regular expressions that can exhibit catastrophic backtracking on non-matching input.\n\nExamples of problematic patterns include `+(a|aa)`, `+(*|?)`, `+(+(a))`, `*(+(a))`, and `+(+(+(a)))`. In local reproduction, these patterns caused multi-second event-loop blocking with relatively short inputs. For example, `+(a|aa)` compiled to `^(?:(?=.)(?:a|aa)+)$` and took about 2 seconds to reject a 41-character non-matching input, while nested patterns such as `+(+(a))` and `*(+(a))` took around 29 seconds to reject a 33-character input on a modern M1 MacBook.\n\nApplications are impacted when they allow untrusted users to supply glob patterns that are passed to `picomatch` for compilation or matching. In those cases, an attacker can cause excessive CPU consumption and block the Node.js event loop, resulting in a denial of service. Applications that only use trusted, developer-controlled glob patterns are much less likely to be exposed in a security-relevant way.\n\n### Patches\nThis issue is fixed in picomatch 4.0.4, 3.0.2 and 2.3.2.\n\nUsers should upgrade to one of these versions or later, depending on their supported release line.\n\n### Workarounds\nIf upgrading is not immediately possible, avoid passing untrusted glob patterns to `picomatch`.\n\nPossible mitigations include:\n- disable extglob support for untrusted patterns by using `noextglob: true`\n- reject or sanitize patterns containing nested extglobs or extglob quantifiers such as `+()` and `*()`\n- enforce strict allowlists for accepted pattern syntax\n- run matching in an isolated worker or separate process with time and resource limits\n- apply application-level request throttling and input validation for any endpoint that accepts glob patterns\n\n### Resources\n- Picomatch repository: https://github.com/micromatch/picomatch\n- `lib/parse.js` and `lib/constants.js` are involved in generating the vulnerable regex forms\n- Comparable ReDoS precedent: CVE-2024-4067 (`micromatch`)\n- Comparable generated-regex precedent: CVE-2024-45296 (`path-to-regexp`)",
11+
"severity": [
12+
{
13+
"type": "CVSS_V3",
14+
"score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
15+
}
16+
],
17+
"affected": [
18+
{
19+
"package": {
20+
"ecosystem": "npm",
21+
"name": "picomatch"
22+
},
23+
"ranges": [
24+
{
25+
"type": "ECOSYSTEM",
26+
"events": [
27+
{
28+
"introduced": "4.0.0"
29+
},
30+
{
31+
"fixed": "4.0.4"
32+
}
33+
]
34+
}
35+
]
36+
},
37+
{
38+
"package": {
39+
"ecosystem": "npm",
40+
"name": "picomatch"
41+
},
42+
"ranges": [
43+
{
44+
"type": "ECOSYSTEM",
45+
"events": [
46+
{
47+
"introduced": "3.0.0"
48+
},
49+
{
50+
"fixed": "3.0.2"
51+
}
52+
]
53+
}
54+
]
55+
},
56+
{
57+
"package": {
58+
"ecosystem": "npm",
59+
"name": "picomatch"
60+
},
61+
"ranges": [
62+
{
63+
"type": "ECOSYSTEM",
64+
"events": [
65+
{
66+
"introduced": "0"
67+
},
68+
{
69+
"fixed": "2.3.2"
70+
}
71+
]
72+
}
73+
]
74+
}
75+
],
76+
"references": [
77+
{
78+
"type": "WEB",
79+
"url": "https://github.com/micromatch/picomatch/security/advisories/GHSA-c2c7-rcm5-vvqj"
80+
},
81+
{
82+
"type": "WEB",
83+
"url": "https://github.com/micromatch/picomatch/commit/5eceecd27543b8e056b9307d69e105ea03618a7d"
84+
},
85+
{
86+
"type": "PACKAGE",
87+
"url": "https://github.com/micromatch/picomatch"
88+
}
89+
],
90+
"database_specific": {
91+
"cwe_ids": [
92+
"CWE-1333"
93+
],
94+
"severity": "HIGH",
95+
"github_reviewed": true,
96+
"github_reviewed_at": "2026-03-25T21:12:07Z",
97+
"nvd_published_at": null
98+
}
99+
}

0 commit comments

Comments
 (0)