Skip to content

Commit 05d4e25

Browse files
committed
Avoid mutating languages array in overlay status functions
Use [...languages].sort() instead of languages.sort() to avoid mutating the caller's array as a side effect.
1 parent 5c583bb commit 05d4e25

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/init-action-post.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/overlay/status.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export async function getOverlayStatus(
8181
const statusFile = path.join(
8282
getTemporaryDirectory(),
8383
"overlay-status",
84-
languages.sort().join("+"),
84+
[...languages].sort().join("+"),
8585
STATUS_FILE_NAME,
8686
);
8787
await fs.promises.mkdir(path.dirname(statusFile), { recursive: true });
@@ -132,7 +132,7 @@ export async function saveOverlayStatus(
132132
const statusFile = path.join(
133133
getTemporaryDirectory(),
134134
"overlay-status",
135-
languages.sort().join("+"),
135+
[...languages].sort().join("+"),
136136
STATUS_FILE_NAME,
137137
);
138138
await fs.promises.mkdir(path.dirname(statusFile), { recursive: true });
@@ -174,5 +174,5 @@ export async function getCacheKey(
174174

175175
// Include the CodeQL version in the cache key so we will try again to use overlay analysis when
176176
// new queries and libraries that may be more efficient are released.
177-
return `codeql-overlay-status-${languages.sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
177+
return `codeql-overlay-status-${[...languages].sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
178178
}

0 commit comments

Comments
 (0)