Move credentialToStr and add tests

Author: mbg

lib/start-proxy-action.js

@@ -12,6 +12,7 @@ import { KnownLanguage } from "./languages";
 import { getActionsLogger, Logger } from "./logging";
 import {
   Credential,
+  credentialToStr,
   getCredentials,
   getDownloadUrl,
   parseLanguage,
@@ -309,10 +310,4 @@ async function getProxyBinaryPath(logger: Logger): Promise<string> {
   return proxyBin;
 }
 
-function credentialToStr(c: Credential): string {
-  return `Type: ${c.type}; Host: ${c.host}; Url: ${c.url} Username: ${
-    c.username
-  }; Password: ${c.password !== undefined}; Token: ${c.token !== undefined}`;
-}
-
 void runWrapper();

src/start-proxy-action.ts

@@ -301,3 +301,20 @@ test("getDownloadUrl returns matching release asset", async (t) => {
   t.is(info.version, defaults.cliVersion);
   t.is(info.url, "url-we-want");
 });
+
+test("credentialToStr - hides passwords/tokens", (t) => {
+  const secret = "password123";
+  const credential = {
+    type: "maven_credential",
+  };
+  t.false(
+    startProxyExports
+      .credentialToStr({ password: secret, ...credential })
+      .includes(secret),
+  );
+  t.false(
+    startProxyExports
+      .credentialToStr({ token: secret, ...credential })
+      .includes(secret),
+  );
+});

src/start-proxy.test.ts

@@ -277,3 +277,14 @@ export async function getDownloadUrl(
     version: UPDATEJOB_PROXY_VERSION,
   };
 }
+
+/**
+ * Pretty-prints a `Credential` value to a string, but hides the actual password or token values.
+ *
+ * @param c The credential to convert to a string.
+ */
+export function credentialToStr(c: Credential): string {
+  return `Type: ${c.type}; Host: ${c.host}; Url: ${c.url} Username: ${
+    c.username
+  }; Password: ${c.password !== undefined}; Token: ${c.token !== undefined}`;
+}