Skip to content

Commit 4869139

Browse files
Copilothenrymercer
andcommitted
Address code review feedback
- Remove awkward blank lines left after removing eslint-disable comments - Add baseUrl to tsconfig.json for proper paths resolution Co-authored-by: henrymercer <14129055+henrymercer@users.noreply.github.com>
1 parent 712b51a commit 4869139

File tree

4 files changed

+1
-4
lines changed

4 files changed

+1
-4
lines changed

src/api-client.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ function mockGetMetaVersionHeader(
5252
};
5353
const spyGetContents = sinon
5454
.stub(client.rest.meta, "get")
55-
5655
.resolves(response as any);
5756
sinon.stub(api, "getApiClient").value(() => client);
5857
return spyGetContents;

src/api-client.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ export async function getGitHubVersionFromApi(
116116

117117
// Doesn't strictly have to be the meta endpoint as we're only
118118
// using the response headers which are available on every request.
119-
120119
const response = await apiClient.rest.meta.get();
121120

122121
// This happens on dotcom, although we expect to have already returned in that

src/config-utils.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ function mockGetContents(
115115
};
116116
const spyGetContents = sinon
117117
.stub(client.rest.repos, "getContent")
118-
119118
.resolves(response as any);
120119
sinon.stub(api, "getApiClient").value(() => client);
121120
sinon.stub(api, "getApiClientWithExternalAuth").value(() => client);
@@ -131,7 +130,6 @@ function mockListLanguages(languages: string[]) {
131130
for (const language of languages) {
132131
response.data[language] = 123;
133132
}
134-
135133
sinon.stub(client.rest.repos, "listLanguages").resolves(response as any);
136134
sinon.stub(api, "getApiClient").value(() => client);
137135
}

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
2626

2727
/* Module Resolution Options */
28+
"baseUrl": ".", /* Base directory to resolve non-absolute module names. */
2829
"esModuleInterop": true, /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
2930
"resolveJsonModule": true,
3031
"paths": {

0 commit comments

Comments
 (0)