Improve type safety by using more specific function types

Author: henrymercer

.eslintrc.json

@@ -51,7 +51,6 @@
         // "temporarily downgraded during transition to eslint
         "files": "**",
         "rules": {
-            "@typescript-eslint/ban-types": "off",
             "@typescript-eslint/explicit-module-boundary-types": "off",
             "@typescript-eslint/no-explicit-any": "off",
             "@typescript-eslint/no-unsafe-assignment": "off",

lib/analyze-action-post-helper.js.map

@@ -1,10 +1,15 @@
 import * as core from "@actions/core";
 
 import * as actionsUtil from "./actions-util";
-import { getConfig } from "./config-utils";
+import { Config, getConfig } from "./config-utils";
 import { getActionsLogger } from "./logging";
 
-export async function run(uploadSarifDebugArtifact: Function) {
+export async function run(
+  uploadSarifDebugArtifact: (
+    config: Config,
+    outputDir: string,
+  ) => Promise<void>,
+) {
   const logger = getActionsLogger();
 
   const config = await getConfig(actionsUtil.getTemporaryDirectory(), logger);

lib/config-utils.js.map

@@ -233,14 +233,14 @@ export interface BetterResolveLanguagesOutput {
 export interface ResolveQueriesOutput {
   byLanguage: {
     [language: string]: {
-      [queryPath: string]: {};
+      [queryPath: string]: object;
     };
   };
   noDeclaredLanguage: {
-    [queryPath: string]: {};
+    [queryPath: string]: object;
   };
   multipleDeclaredLanguages: {
-    [queryPath: string]: {};
+    [queryPath: string]: object;
   };
 }
 

lib/init-action-post-helper.js.map

@@ -81,7 +81,7 @@ function createConfigFile(inputFileContents: string, tmpDir: string): string {
   return configFilePath;
 }
 
-type GetContentsResponse = { content?: string } | Array<{}>;
+type GetContentsResponse = { content?: string } | object[];
 
 function mockGetContents(
   content: GetContentsResponse,

src/analyze-action-post-helper.ts

@@ -1065,7 +1065,7 @@ function createRegistriesBlock(registries: RegistryConfigWithCredentials[]): {
  */
 export async function wrapEnvironment(
   env: Record<string, string | undefined>,
-  operation: Function,
+  operation: () => Promise<void>,
 ) {
   // Remember the original env
   const oldEnv = { ...process.env };

src/codeql.ts

@@ -163,9 +163,12 @@ export async function tryUploadSarifIfRunFailed(
 }
 
 export async function run(
-  uploadDatabaseBundleDebugArtifact: Function,
-  uploadLogsDebugArtifact: Function,
-  printDebugLogs: Function,
+  uploadDatabaseBundleDebugArtifact: (
+    config: Config,
+    logger: Logger,
+  ) => Promise<void>,
+  uploadLogsDebugArtifact: (config: Config) => Promise<void>,
+  printDebugLogs: (config: Config) => Promise<void>,
   config: Config,
   repositoryNwo: RepositoryNwo,
   features: FeatureEnablement,