Added RULE 15-4

Author: s-samadi

c/misra/src/rules/RULE-15-4/LoopIterationCondition.ql

@@ -1,18 +1,29 @@
 /**
  * @id c/misra/loop-iteration-condition
  * @name RULE-15-4: There should be no more than one break or goto statement used to terminate any iteration statement
- * @description 
+ * @description More than one break or goto statement in iteration conditions may lead to
+ *              readability and maintainability issues.
  * @kind problem
  * @precision very-high
  * @problem.severity error
  * @tags external/misra/id/rule-15-4
+ *       maintainability
+ *       readability
  *       external/misra/obligation/advisory
  */
 
 import cpp
 import codingstandards.c.misra
 
-from
+from Loop loop
 where
-  not isExcluded(x, Statements2Package::loopIterationConditionQuery()) and
-select
+  not isExcluded(loop, Statements2Package::loopIterationConditionQuery()) and
+  count(Stmt terminationStmt |
+    loop.getChildStmt*() = terminationStmt and
+    (
+      terminationStmt instanceof BreakStmt
+      or
+      terminationStmt instanceof GotoStmt
+    )
+  ) > 1
+select loop, "$@ statement contains more than one break or goto statement", loop, "Iteration"

c/misra/test/rules/RULE-15-4/LoopIterationCondition.expected

@@ -1 +1,2 @@
-No expected results have yet been specified
+| test.c:24:3:32:3 | for(...;...;...) ... | $@ statement contains more than one break or goto statement | test.c:24:3:32:3 | for(...;...;...) ... | Iteration |
+| test.c:38:3:45:3 | while (...) ... | $@ statement contains more than one break or goto statement | test.c:38:3:45:3 | while (...) ... | Iteration |

c/misra/test/rules/RULE-15-4/test.c

@@ -0,0 +1,46 @@
+void f1() {
+L1:;
+
+  for (int k = 0; k < 10; k++) { // COMPLIANT
+    ;
+  }
+
+  for (int i = 0; i < 10; i++) { // COMPLIANT
+    if (i > 5) {
+      break;
+    }
+  }
+
+  for (int j = 0; j < 10; j++) { // COMPLIANT
+    goto L1;
+  }
+}
+
+void f2() {
+L1:;
+
+  int k = 0;
+
+  for (int i = 0; i < 10; i++) { // NON_COMPLIANT
+    if (i > 5) {
+      break;
+    }
+    if (i < 10) {
+      break;
+    }
+    goto L1;
+  }
+
+  while (k < 10) { // COMPLIANT
+    ;
+  }
+
+  while (k < 10) { // NON_COMPLIANT
+    if (k > 5) {
+      break;
+    }
+    while (k < 3) { // COMPLIANT
+      goto L1;
+    }
+  }
+}

rule_packages/c/Statements2.json

@@ -47,13 +47,16 @@
       },
       "queries": [
         {
-          "description": "",
+          "description": "More than one break or goto statement in iteration conditions may lead to readability and maintainability issues.",
           "kind": "problem",
           "name": "There should be no more than one break or goto statement used to terminate any iteration statement",
           "precision": "very-high",
           "severity": "error",
           "short_name": "LoopIterationCondition",
-          "tags": []
+          "tags": [
+            "maintainability",
+            "readability"
+          ]
         }
       ],
       "title": "There should be no more than one break or goto statement used to terminate any iteration statement"