STR53-C:

Result deduced from copy contructor in `getInitialContainerSize`

Author: mbaluda

.vscode/settings.json

@@ -0,0 +1,20 @@
+{
+    "sarif-viewer.connectToGithubCodeScanning": "off",
+    "codeQL.cli.executablePath": "/Users/mauro/GitHub/coding-standards/codeql-bundle-20220908/codeql",
+    "codeQL.runningQueries.numberOfThreads": 0,
+    "codeQL.runningTests.numberOfThreads": 0,
+    "codeQL.runningQueries.autoSave": true,
+    "codeQL.runningQueries.debug": true,
+    "files.associations": {
+        "*.jq": "json",
+        "*.py": "python",
+        "*.expected": "csv (pipe)",
+        "*.actual": "csv (pipe)",
+        "*.qls": "yaml",
+        "*.qcc": "cpp",
+        "*.gcc": "cpp",
+        "iosfwd": "cpp",
+        "fstream": "cpp",
+        "iostream": "cpp"
+    }
+}

cpp/common/src/codingstandards/cpp/rules/containeraccesswithoutrangecheck/ContainerAccessWithoutRangeCheck.qll

@@ -185,6 +185,11 @@ class StringContainerConstructorCall extends ContainerConstructorCall {
     c.getParameter(1).getType() = stringInstantiation.getConstAllocatorReferenceType() and
     result = getArgument(0).getValue().length()
     or
+    // from c-string copy constructor
+    c.getNumberOfParameters() = 1 and
+    c.getParameter(0).getType() = stringInstantiation.getValueType() and
+    result = getArgument(0).getValue().length()
+    or
     // Lower bound of an explicit size argument
     result = lowerBound(getInitialContainerSizeExpr().getFullyConverted())
   }

scripts/build_test_database.py

@@ -47,7 +47,7 @@
     exit(1)
 
 # get the codeql version 
-res = subprocess.run(['codeql', 'version', '--format', 'json'], stdout=subprocess.PIPE)
+res = subprocess.run(['/Users/mauro/GitHub/coding-standards/codeql-bundle-20220908/codeql', 'version', '--format', 'json'], stdout=subprocess.PIPE)
 res_json = json.loads(res.stdout) 
 CODEQL_VERSION=res_json["version"]
 
@@ -61,10 +61,10 @@
 
 elif LANGUAGE == "c":
     FILES = ' '.join([f for f in all_files if f.endswith('.c')])
-    BUILD_COMMAND=f"clang -fsyntax-only {FILES}"
+    BUILD_COMMAND=f"clang -fsyntax-only -I../../../../common/test/includes/custom-library {FILES}"
 
 ITERATION=0
 while os.path.exists(f"databases/{RULE}+{ITERATION}@{CODEQL_VERSION}"):
     ITERATION = ITERATION + 1 
 
-os.system(f"codeql database create -l cpp -s {LANGUAGE}/{STANDARD}/test/rules/{RULE} --command=\"{BUILD_COMMAND}\" databases/{RULE}+{ITERATION}@{CODEQL_VERSION}")
+os.system(f"/Users/mauro/GitHub/coding-standards/codeql-bundle-20220908/codeql database create -l cpp -s {LANGUAGE}/{STANDARD}/test/rules/{RULE} --command=\"{BUILD_COMMAND}\" databases/{RULE}+{ITERATION}@{CODEQL_VERSION}")