Rule 14.3: Exclude results in macro expansions

lcartey · lcartey · commit 944f7271e119 · 2023-03-22T23:42:53.000Z
Expansions of macros may have expressions which are seemingly
invariant, but are different per invocation. We therefore exclude
all such results.
diff --git a/c/misra/src/rules/RULE-14-3/ControllingExprInvariant.ql b/c/misra/src/rules/RULE-14-3/ControllingExprInvariant.ql
@@ -52,5 +52,7 @@ where
       )
     ) and
     message = "Controlling expression in switch statement has invariant value."
-  )
+  ) and
+  // Exclude macros, which may generate seemingly invariant expressions
+  not expr.isAffectedByMacro()
 select expr, message

Original file line number	Diff line number	Diff line change
`@@ -52,5 +52,7 @@ where`
`52`	`52`	`)`
`53`	`53`	`) and`
`54`	`54`	`message = "Controlling expression in switch statement has invariant value."`
`55`		`- )`
	`55`	`+ ) and`
	`56`	`+ // Exclude macros, which may generate seemingly invariant expressions`
	`57`	`+ not expr.isAffectedByMacro()`
`56`	`58`	`select expr, message`