factor semver to separate function

KyFaSt · KyFaSt · commit 023e8cbe3e00 · 2024-10-21T20:59:42.000-04:00
diff --git a/ql/lib/codeql/actions/security/UseOfUnversionedImmutableAction.qll b/ql/lib/codeql/actions/security/UseOfUnversionedImmutableAction.qll
@@ -6,6 +6,11 @@ class UnversionedImmutableAction extends UsesStep {
   UnversionedImmutableAction() {
     immutableActionsDataModel(immutable_action) and
     this.getCallee() = immutable_action and
-    not this.getVersion().regexpMatch("^(v)?[0-9]+(\\.[0-9]+)*(\\.[xX])?$")
+    isNotSemVer(this.getVersion())
   }
 }
+
+bindingset[version]
+predicate isNotSemVer(string version) {
+  not version.regexpMatch("^(v)?[0-9]+(\\.[0-9]+)*(\\.[xX])?$")
+}

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,11 @@ class UnversionedImmutableAction extends UsesStep {`
`6`	`6`	`UnversionedImmutableAction() {`
`7`	`7`	`immutableActionsDataModel(immutable_action) and`
`8`	`8`	`this.getCallee() = immutable_action and`
`9`		`- not this.getVersion().regexpMatch("^(v)?[0-9]+(\\.[0-9]+)*(\\.[xX])?$")`
	`9`	`+ isNotSemVer(this.getVersion())`
`10`	`10`	`}`
`11`	`11`	`}`
	`12`	`+`
	`13`	`+bindingset[version]`
	`14`	`+predicate isNotSemVer(string version) {`
	`15`	`+ not version.regexpMatch("^(v)?[0-9]+(\\.[0-9]+)*(\\.[xX])?$")`
	`16`	`+}`