change regexpMatch to regexpFind

erik-krogh · erik-krogh · commit 051de247b0fa · 2020-02-24T13:11:30.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/security/UselessUseOfCat.qll b/javascript/ql/src/semmle/javascript/security/UselessUseOfCat.qll
@@ -102,7 +102,7 @@ class UselessCat extends CommandCall {
       )
     ) and
     // wildcards, pipes, redirections, other bash features, and multiple files (spaces) are OK.
-    not getNonCommandConstantString().regexpMatch(".*(\\*|\\||>|<| |\\$|&|,|\\`).*") and
+    not exists(getNonCommandConstantString().regexpFind("\\*|\\||>|<| |\\$|&|,|\\`", _, _)) and
     // Only acceptable option is "encoding", everything else is non-trivial to emulate with fs.readFile.
     (
       not exists(getOptionsArg())

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ class UselessCat extends CommandCall {`
`102`	`102`	`)`
`103`	`103`	`) and`
`104`	`104`	`// wildcards, pipes, redirections, other bash features, and multiple files (spaces) are OK.`
`105`		- not getNonCommandConstantString().regexpMatch(".(\\\|\\\|\|>\|<\| \|\\$\|&\|,\|\\`).*") and
	`105`	+ not exists(getNonCommandConstantString().regexpFind("\\*\|\\\|\|>\|<\| \|\\$\|&\|,\|\\`", _, _)) and
`106`	`106`	`// Only acceptable option is "encoding", everything else is non-trivial to emulate with fs.readFile.`
`107`	`107`	`(`
`108`	`108`	`not exists(getOptionsArg())`