Rename sink kind to "credentials-password" to match naming convention

Author: egregius313

java/ql/lib/ext/ch.ethz.ssh2.model.yml

@@ -5,4 +5,4 @@ extensions:
     data:
       - ["ch.ethz.ssh2", "Connection", False, "authenticateWithNone", "(String)", "", "Argument[0]", "credential-username", "manual"]
       - ["ch.ethz.ssh2", "Connection", False, "authenticateWithPassword", "(String,String)", "", "Argument[0]", "credential-username", "manual"]
-      - ["ch.ethz.ssh2", "Connection", False, "authenticateWithPassword", "(String,String)", "", "Argument[1]", "credential-password", "manual"]
+      - ["ch.ethz.ssh2", "Connection", False, "authenticateWithPassword", "(String,String)", "", "Argument[1]", "credentials-password", "manual"]

java/ql/lib/ext/com.azure.identity.model.yml

@@ -4,5 +4,5 @@ extensions:
       extensible: sinkModel
     data:
       - ["com.azure.identity", "ClientSecretCredentialBuilder", False, "clientSecret", "(String)", "", "Argument[0]", "crypto-parameter", "manual"]
-      - ["com.azure.identity", "UsernamePasswordCredentialBuilder", False, "password", "(String)", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.azure.identity", "UsernamePasswordCredentialBuilder", False, "password", "(String)", "", "Argument[0]", "credentials-password", "manual"]
       - ["com.azure.identity", "UsernamePasswordCredentialBuilder", False, "username", "(String)", "", "Argument[0]", "credential-username", "manual"]

java/ql/lib/ext/com.jcraft.jsch.model.yml

@@ -3,24 +3,24 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(Identity,byte[])", "", "Argument[1]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(Identity,byte[])", "", "Argument[1]", "credentials-password", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String)", "", "Argument[0]", "crypto-parameter", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[])", "", "Argument[0]", "crypto-parameter", "manual"]
-      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[])", "", "Argument[1]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[])", "", "Argument[1]", "credentials-password", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[],byte[],byte[])", "", "Argument[0]", "credential-username", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[],byte[],byte[])", "", "Argument[1]", "crypto-parameter", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[],byte[],byte[])", "", "Argument[2]", "crypto-parameter", "manual"]
-      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[],byte[],byte[])", "", "Argument[3]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,byte[],byte[],byte[])", "", "Argument[3]", "credentials-password", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String)", "", "Argument[0]", "crypto-parameter", "manual"]
-      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String)", "", "Argument[1]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String)", "", "Argument[1]", "credentials-password", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String,byte[])", "", "Argument[0]", "crypto-parameter", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String,byte[])", "", "Argument[1]", "crypto-parameter", "manual"]
-      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String,byte[])", "", "Argument[2]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "JSch", True, "addIdentity", "(String,String,byte[])", "", "Argument[2]", "credentials-password", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "getSession", "(String,String,int)", "", "Argument[1]", "request-forgery", "ai-manual"]
       - ["com.jcraft.jsch", "JSch", True, "getSession", "(String,String)", "", "Argument[0]", "credential-username", "manual"]
       - ["com.jcraft.jsch", "JSch", True, "getSession", "(String,String,int)", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.jcraft.jsch", "Session", False, "setPassword", "(String)", "", "Argument[0]", "credential-password", "manual"]
-      - ["com.jcraft.jsch", "Session", False, "setPassword", "(byte[])", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.jcraft.jsch", "Session", False, "setPassword", "(String)", "", "Argument[0]", "credentials-password", "manual"]
+      - ["com.jcraft.jsch", "Session", False, "setPassword", "(byte[])", "", "Argument[0]", "credentials-password", "manual"]
   - addsTo:
       pack: codeql/java-all
       extensible: summaryModel

java/ql/lib/ext/com.microsoft.sqlserver.jdbc.model.yml

@@ -4,6 +4,6 @@ extensions:
       extensible: sinkModel
     data:
       - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "getConnection", "(String,String)", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "getConnection", "(String,String)", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "setPassword", "(String)", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "getConnection", "(String,String)", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "setPassword", "(String)", "", "Argument[0]", "credentials-password", "manual"]
       - ["com.microsoft.sqlserver.jdbc", "SQLServerDataSource", False, "setUser", "(String)", "", "Argument[0]", "credential-username", "manual"]

java/ql/lib/ext/com.mongodb.model.yml

@@ -4,12 +4,12 @@ extensions:
       extensible: sinkModel
     data:
       - ["com.mongodb", "MongoCredential", False, "createCredential", "", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.mongodb", "MongoCredential", False, "createCredential", "", "", "Argument[2]", "credential-password", "manual"]
+      - ["com.mongodb", "MongoCredential", False, "createCredential", "", "", "Argument[2]", "credentials-password", "manual"]
       - ["com.mongodb", "MongoCredential", False, "createGSSAPICredential", "", "", "Argument[0]", "credential-username", "manual"]
       - ["com.mongodb", "MongoCredential", False, "createMongoCRCredential", "", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.mongodb", "MongoCredential", False, "createMongoCRCredential", "", "", "Argument[2]", "credential-password", "manual"]
+      - ["com.mongodb", "MongoCredential", False, "createMongoCRCredential", "", "", "Argument[2]", "credentials-password", "manual"]
       - ["com.mongodb", "MongoCredential", False, "createMongoX509Credential", "", "", "Argument[0]", "credential-username", "manual"]
       - ["com.mongodb", "MongoCredential", False, "createPlainCredential", "", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.mongodb", "MongoCredential", False, "createPlainCredential", "", "", "Argument[2]", "credential-password", "manual"]
+      - ["com.mongodb", "MongoCredential", False, "createPlainCredential", "", "", "Argument[2]", "credentials-password", "manual"]
       - ["com.mongodb", "MongoCredential", False, "createScramSha1Credential", "", "", "Argument[0]", "credential-username", "manual"]
-      - ["com.mongodb", "MongoCredential", False, "createScramSha1Credential", "", "", "Argument[2]", "credential-password", "manual"]
+      - ["com.mongodb", "MongoCredential", False, "createScramSha1Credential", "", "", "Argument[2]", "credentials-password", "manual"]

java/ql/lib/ext/com.sshtools.j2ssh.authentication.model.yml

@@ -3,6 +3,6 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.sshtools.j2ssh.authentication", "PasswordAuthenticationClient", False, "setPassword", "(String)", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.sshtools.j2ssh.authentication", "PasswordAuthenticationClient", False, "setPassword", "(String)", "", "Argument[0]", "credentials-password", "manual"]
       - ["com.sshtools.j2ssh.authentication", "PasswordAuthenticationClient", True, "setUsername", "(String)", "", "Argument[0]", "credential-username", "manual"]
       - ["com.sshtools.j2ssh.authentication", "SshAuthenticationClient", True, "setUsername", "(String)", "", "Argument[0]", "credential-username", "manual"]

java/ql/lib/ext/com.sun.crypto.provider.model.yml

@@ -3,14 +3,14 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineGetKey", "(String,char[])", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineLoad", "(InputStream,char[])", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineSetKeyEntry", "(String,Key,char[],Certificate[])", "", "Argument[2]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineStore", "(OutputStream,char[])", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "JceKeyStore", False, "getPreKeyedHash", "(char[])", "", "Argument[0]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "KeyProtector", False, "KeyProtector", "(char[])", "", "Argument[0]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "PBKDF2KeyImpl", False, "deriveKey", "(Mac,byte[],byte[],int,int)", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.crypto.provider", "PBKDF2KeyImpl", False, "getPasswordBytes", "(char[])", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineGetKey", "(String,char[])", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineLoad", "(InputStream,char[])", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineSetKeyEntry", "(String,Key,char[],Certificate[])", "", "Argument[2]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "JceKeyStore", False, "engineStore", "(OutputStream,char[])", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "JceKeyStore", False, "getPreKeyedHash", "(char[])", "", "Argument[0]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "KeyProtector", False, "KeyProtector", "(char[])", "", "Argument[0]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "PBKDF2KeyImpl", False, "deriveKey", "(Mac,byte[],byte[],int,int)", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.crypto.provider", "PBKDF2KeyImpl", False, "getPasswordBytes", "(char[])", "", "Argument[0]", "credentials-password", "manual"]
       - ["com.sun.crypto.provider", "AESCipher", False, "engineUnwrap", "(byte[],String,int)", "", "Argument[0]", "crypto-parameter", "manual"]
       - ["com.sun.crypto.provider", "AESCrypt", False, "init", "(boolean,String,byte[])", "", "Argument[2]", "crypto-parameter", "manual"]
       - ["com.sun.crypto.provider", "AESWrapCipher", False, "engineUnwrap", "(byte[],String,int)", "", "Argument[0]", "crypto-parameter", "manual"]

java/ql/lib/ext/com.sun.net.httpserver.model.yml

@@ -3,6 +3,6 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.sun.net.httpserver", "BasicAuthenticator", False, "checkCredentials", "(String,String)", "", "Argument[1]", "credential-password", "manual"]
+      - ["com.sun.net.httpserver", "BasicAuthenticator", False, "checkCredentials", "(String,String)", "", "Argument[1]", "credentials-password", "manual"]
       - ["com.sun.net.httpserver", "BasicAuthenticator", False, "checkCredentials", "(String,String)", "", "Argument[0]", "credential-username", "manual"]
       - ["com.sun.net.httpserver", "HttpPrincipal", False, "HttpPrincipal", "(String,String)", "", "Argument[0]", "credential-username", "manual"]

java/ql/lib/ext/com.sun.net.ssl.model.yml

@@ -3,6 +3,6 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.sun.net.ssl", "KeyManagerFactory", False, "init", "(KeyStore,char[])", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.net.ssl", "KeyManagerFactorySpi", False, "engineInit", "(KeyStore,char[])", "", "Argument[1]", "credential-password", "manual"]
-      - ["com.sun.net.ssl", "KeyManagerFactorySpiWrapper", False, "engineInit", "(KeyStore,char[])", "", "Argument[1]", "credential-password", "manual"]
+      - ["com.sun.net.ssl", "KeyManagerFactory", False, "init", "(KeyStore,char[])", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.net.ssl", "KeyManagerFactorySpi", False, "engineInit", "(KeyStore,char[])", "", "Argument[1]", "credentials-password", "manual"]
+      - ["com.sun.net.ssl", "KeyManagerFactorySpiWrapper", False, "engineInit", "(KeyStore,char[])", "", "Argument[1]", "credentials-password", "manual"]

java/ql/lib/ext/com.sun.rowset.model.yml

@@ -3,6 +3,6 @@ extensions:
       pack: codeql/java-all
       extensible: sinkModel
     data:
-      - ["com.sun.rowset", "JdbcRowSetImpl", False, "JdbcRowSetImpl", "(String,String,String)", "", "Argument[2]", "credential-password", "manual"]
-      - ["com.sun.rowset", "JdbcRowSetImpl", False, "setPassword", "(String)", "", "Argument[0]", "credential-password", "manual"]
+      - ["com.sun.rowset", "JdbcRowSetImpl", False, "JdbcRowSetImpl", "(String,String,String)", "", "Argument[2]", "credentials-password", "manual"]
+      - ["com.sun.rowset", "JdbcRowSetImpl", False, "setPassword", "(String)", "", "Argument[0]", "credentials-password", "manual"]
       - ["com.sun.rowset", "JdbcRowSetImpl", False, "JdbcRowSetImpl", "(String,String,String)", "", "Argument[1]", "credential-username", "manual"]