C++: ArithmeticWithExtremeValues

Author: d10c

cpp/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql

@@ -114,12 +114,10 @@ module Config implements DataFlow::ConfigSig {
     )
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 122 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql@126:8:126:9)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 122 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql@126:8:126:9)
+    exists(VariableAccess va | result = va.getLocation() | isSink(sink, va, _))
   }
 }