Update python/ql/src/Exceptions/UnguardedNextInGenerator.ql

BekaValentine · RasmusWL · web-flow · commit 06f094731808 · 2020-03-18T14:16:00.000-07:00
Co-Authored-By: Rasmus Wriedt Larsen &lt;rasmuswriedtlarsen@gmail.com&gt;
diff --git a/python/ql/src/Exceptions/UnguardedNextInGenerator.ql b/python/ql/src/Exceptions/UnguardedNextInGenerator.ql
@@ -29,7 +29,7 @@ predicate call_to_next(CallNode call, ControlFlowNode iter) {
 }
 
 predicate call_to_next_has_default(CallNode call) {
-    exists(call.getArg(1))
+    exists(call.getArg(1)) or exists(call.getArgByName("default"))
 }
 
 predicate guarded_not_empty_sequence(EssaVariable sequence) {
@@ -63,4 +63,3 @@ not exists(Comp comp | comp.contains(call.getNode())) and
 not stop_iteration_handled(call)
 
 select call, "Call to next() in a generator"
-

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ predicate call_to_next(CallNode call, ControlFlowNode iter) {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`predicate call_to_next_has_default(CallNode call) {`
`32`		`- exists(call.getArg(1))`
	`32`	`+ exists(call.getArg(1)) or exists(call.getArgByName("default"))`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`predicate guarded_not_empty_sequence(EssaVariable sequence) {`
`@@ -63,4 +63,3 @@ not exists(Comp comp \| comp.contains(call.getNode())) and`
`63`	`63`	`not stop_iteration_handled(call)`
`64`	`64`
`65`	`65`	`select call, "Call to next() in a generator"`
`66`		`-`