Fix getMaxIntValue to accept bitSize 64

owen-mc · owen-mc · commit 0ed01453b9bc · 2023-10-26T12:27:43.000+01:00
diff --git a/go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll b/go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll
@@ -5,7 +5,7 @@ import go
  * is true, unsigned otherwise) with `bitSize` bits.
  */
 float getMaxIntValue(int bitSize, boolean isSigned) {
-  bitSize in [8, 16, 32] and
+  bitSize in [8, 16, 32, 64] and
   (
     isSigned = true and result = 2.pow(bitSize - 1) - 1
     or

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import go`
`5`	`5`	* is true, unsigned otherwise) with `bitSize` bits.
`6`	`6`	`*/`
`7`	`7`	`float getMaxIntValue(int bitSize, boolean isSigned) {`
`8`		`- bitSize in [8, 16, 32] and`
	`8`	`+ bitSize in [8, 16, 32, 64] and`
`9`	`9`	`(`
`10`	`10`	`isSigned = true and result = 2.pow(bitSize - 1) - 1`
`11`	`11`	`or`