Binary: Add a few helper member predicates.

Author: MathiasVP

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/Instruction.qll

@@ -166,6 +166,8 @@ class CallInstruction extends Instruction {
 
   Function getStaticTarget() { result = TMkFunction(te.getStaticCallTarget(tag)) }
 
+  CallTargetOperand getTargetOperand() { result = this.getAnOperand() }
+
   override string getImmediateValue() { result = this.getStaticTarget().getName() }
 }
 

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/Operand.qll

@@ -71,3 +71,7 @@ class ConditionJumpTargetOperand extends Operand {
 class JumpTargetOperand extends Operand {
   override JumpTargetTag operandTag;
 }
+
+class CallTargetOperand extends Operand {
+  override CallTargetTag operandTag;
+}

binary/ql/lib/semmle/code/binary/ast/ir/internal/InstructionSig.qll

@@ -28,6 +28,8 @@ signature module InstructionSig {
     Function getEnclosingFunction();
 
     OperandTag getOperandTag();
+
+    Location getLocation();
   }
 
   class StoreValueOperand extends Operand;
@@ -48,6 +50,8 @@ signature module InstructionSig {
 
   class RightOperand extends Operand;
 
+  class CallTargetOperand extends Operand;
+
   class InstructionTag {
     string toString();
   }
@@ -160,6 +164,8 @@ signature module InstructionSig {
     BasicBlock getBasicBlock();
 
     InstructionTag getInstructionTag();
+
+    Operand getFirstOperand();
   }
 
   class RetInstruction extends Instruction;
@@ -221,6 +227,12 @@ signature module InstructionSig {
   }
 
   class CallInstruction extends Instruction {
+    CallTargetOperand getTargetOperand();
+
+    /**
+     * Gets the static target of this function call, if it is known (and the
+     * function exists in the database).
+     */
     Function getStaticTarget();
   }
 
@@ -248,5 +260,7 @@ signature module InstructionSig {
     Function getEnclosingFunction();
 
     Location getLocation();
+
+    string toString();
   }
 }

binary/ql/lib/semmle/code/binary/ast/ir/internal/TransformInstruction/TransformInstruction.qll

@@ -659,6 +659,8 @@ module Transform<InstructionSig Input> {
         )
       }
 
+      CallTargetOperand getTargetOperand() { result = this.getAnOperand() }
+
       override string getImmediateValue() { result = this.getStaticTarget().getName() }
     }
 
@@ -974,6 +976,10 @@ module Transform<InstructionSig Input> {
       LeftOperand() { this.getOperandTag() instanceof LeftTag }
     }
 
+    class CallTargetOperand extends Operand {
+      CallTargetOperand() { this.getOperandTag() instanceof CallTargetTag }
+    }
+
     class RightOperand extends Operand {
       RightOperand() { this.getOperandTag() instanceof RightTag }
     }