Skip to content

Commit 1169f9e

Browse files
committed
Assignment through out arg is causing too many FPs.
1 parent 662119a commit 1169f9e

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModificationPrecise.ql

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,16 @@ class OperationSource extends Expr {
204204
class YearFieldAssignmentNode extends DataFlow::Node {
205205
YearFieldAssignmentNode() {
206206
this.asExpr() instanceof YearFieldAssignment
207-
or
208-
this.asDefiningArgument() instanceof YearFieldAccess
209-
or
210-
// TODO: is there a better way to do this?
211-
// i.e., without having to be cognizant of the addressof
212-
// occurring, especially if this occurs on a dataflow
213-
exists(AddressOfExpr aoe |
214-
aoe = this.asDefiningArgument() and
215-
aoe.getOperand() instanceof YearFieldAccess
216-
)
207+
// or
208+
// this.asDefiningArgument() instanceof YearFieldAccess
209+
// or
210+
// // TODO: is there a better way to do this?
211+
// // i.e., without having to be cognizant of the addressof
212+
// // occurring, especially if this occurs on a dataflow
213+
// exists(AddressOfExpr aoe |
214+
// aoe = this.asDefiningArgument() and
215+
// aoe.getOperand() instanceof YearFieldAccess
216+
// )
217217
}
218218

219219
YearFieldAccess getYearFieldAccess() {

0 commit comments

Comments
 (0)