JS: Update getFallbackTypeAnnotation

asgerf · asgerf · commit 12cc228946a0 · 2020-05-18T22:42:12.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
@@ -229,7 +229,7 @@ module DataFlow {
      */
     private JSDocTypeExpr getFallbackTypeAnnotation() {
       exists(BindingPattern pattern |
-        this = lvalueNode(pattern) and
+        this = valueNode(pattern) and
         not ast_node_type(pattern, _) and
         result = pattern.getTypeAnnotation()
       )

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ module DataFlow {`
`229`	`229`	`*/`
`230`	`230`	`private JSDocTypeExpr getFallbackTypeAnnotation() {`
`231`	`231`	`exists(BindingPattern pattern \|`
`232`		`- this = lvalueNode(pattern) and`
	`232`	`+ this = valueNode(pattern) and`
`233`	`233`	`not ast_node_type(pattern, _) and`
`234`	`234`	`result = pattern.getTypeAnnotation()`
`235`	`235`	`)`