C++: Construct fewer strings.

MathiasVP · MathiasVP · commit 1c9a526afa18 · 2023-02-06T15:18:15.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/security/Encryption.qll b/cpp/ql/lib/semmle/code/cpp/security/Encryption.qll
@@ -64,7 +64,7 @@ predicate isInsecureEncryption(string name) { name.regexpMatch(getInsecureAlgori
  */
 bindingset[name]
 predicate isEncryptionAdditionalEvidence(string name) {
-  name.toUpperCase().matches("%" + ["CRYPT", "CODE", "CODING", "CBC", "KEY", "CIPHER", "MAC"] + "%")
+  name.regexpMatch("(?i).*" + ["crypt", "code", "coding", "cbc", "key", "cipher", "mac"] + ".*")
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ predicate isInsecureEncryption(string name) { name.regexpMatch(getInsecureAlgori`
`64`	`64`	`*/`
`65`	`65`	`bindingset[name]`
`66`	`66`	`predicate isEncryptionAdditionalEvidence(string name) {`
`67`		`- name.toUpperCase().matches("%" + ["CRYPT", "CODE", "CODING", "CBC", "KEY", "CIPHER", "MAC"] + "%")`
	`67`	`+ name.regexpMatch("(?i)." + ["crypt", "code", "coding", "cbc", "key", "cipher", "mac"] + ".")`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/**`