Swift: Fix mistake caught by QL-for-QL.

geoffw0 · geoffw0 · commit 1f69fff26cc4 · 2023-02-03T19:15:08.000Z
diff --git a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Collection.qll b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Collection.qll
@@ -26,7 +26,7 @@ private class CollectionSummaries extends SummaryModelCsv {
         ";Collection;true;split(separator:maxSplits:omittingEmptySubsequences:);;;Argument[-1];ReturnValue;taint",
         ";Collection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;remove(at:);;;Argument[-1];ReturnValue;taint",
-        ";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",
+        ";RangeReplaceableCollection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",
         ";BidirectionalCollection;true;joined(separator:);;;Argument[-1..0];ReturnValue;taint",
       ]

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ private class CollectionSummaries extends SummaryModelCsv {`
`26`	`26`	`";Collection;true;split(separator:maxSplits:omittingEmptySubsequences:);;;Argument[-1];ReturnValue;taint",`
`27`	`27`	`";Collection;true;removeFirst();;;Argument[-1];ReturnValue;taint",`
`28`	`28`	`";RangeReplaceableCollection;true;remove(at:);;;Argument[-1];ReturnValue;taint",`
`29`		`- ";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",`
	`29`	`+ ";RangeReplaceableCollection;true;removeFirst();;;Argument[-1];ReturnValue;taint",`
`30`	`30`	`";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",`
`31`	`31`	`";BidirectionalCollection;true;joined(separator:);;;Argument[-1..0];ReturnValue;taint",`
`32`	`32`	`]`