C++: UseOfHttp

d10c · d10c · commit 1f915b08fcea · 2025-07-11T14:42:39.000+02:00
diff --git a/cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql b/cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql
@@ -88,9 +88,13 @@ module HttpStringToUrlOpenConfig implements DataFlow::ConfigSig {
     )
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects source.asIndirectExpr (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql@98:8:98:10)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSourceLocation(DataFlow::Node source) {
+    result = source.asIndirectExpr().getLocation()
   }
+
+  Location getASelectedSinkLocation(DataFlow::Node sink) { none() }
 }
 
 module HttpStringToUrlOpen = TaintTracking::Global<HttpStringToUrlOpenConfig>;

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,13 @@ module HttpStringToUrlOpenConfig implements DataFlow::ConfigSig {`
`88`	`88`	`)`
`89`	`89`	`}`
`90`	`90`
`91`		`- predicate observeDiffInformedIncrementalMode() {`
`92`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects source.asIndirectExpr (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql@98:8:98:10)`
	`91`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`92`	`+`
	`93`	`+ Location getASelectedSourceLocation(DataFlow::Node source) {`
	`94`	`+ result = source.asIndirectExpr().getLocation()`
`93`	`95`	`}`
	`96`	`+`
	`97`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) { none() }`
`94`	`98`	`}`
`95`	`99`
`96`	`100`	`module HttpStringToUrlOpen = TaintTracking::Global<HttpStringToUrlOpenConfig>;`