Update cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql

Co-authored-by: Josh Brown <jb1@microsoft.com>

Author: bdrodes

cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql

@@ -136,32 +136,33 @@ class IgnorableCharLiteralArithmetic extends IgnorableOperation {
 bindingset[c]
 predicate isLikelyConversionConstant(int c) {
   exists(int i | i = c.abs() |
-    //| i >= 100)
-    i = 146097 or // days in 400-year Gregorian cycle
-    i = 36524 or // days in 100-year Gregorian subcycle
-    i = 1461 or // days in 4-year cycle (incl. 1 leap)
-    i = 32044 or // Fliegel–van Flandern JDN epoch shift
-    i = 1721425 or // JDN of 0001‑01‑01 (Gregorian)
-    i = 1721119 or // alt epoch offset
-    i = 2400000 or // MJD → JDN conversion
-    i = 2400001 or // alt MJD → JDN conversion
-    i = 2141 or // fixed‑point month/day extraction
-    i = 65536 or // observed in some conversions
-    i = 7834 or // observed in some conversions
-    i = 256 or // observed in some conversions
-    i = 292275056 or // qdatetime.h Qt Core year range first year constant
-    i = 292278994 or // qdatetime.h Qt Core year range last year constant
-    i = 1601 or // Windows FILETIME epoch start year
-    i = 1970 or // Unix epoch start year
-    i = 70 or // Unix epoch start year short form
-    i = 1899 or // Observed in uses with 1900 to address off by one scenarios
-    i = 1900 or // Used when converting a 2 digit year
-    i = 2000 or // Used when converting a 2 digit year
-    i = 1400 or // Hijri base year, used when converting a 2 digit year
-    i = 1980 or // FAT filesystem epoch start year
-    i = 227013 or // constant observed for Hirji year conversion, and Hirji years are not applicable for gregorian leap year
-    i = 10631 or // constant observed for Hirji year conversion, and Hirji years are not applicable for gregorian leap year
-    i = 0
+    i = [
+      146097, // days in 400-year Gregorian cycle
+      36524, // days in 100-year Gregorian subcycle
+      1461, // days in 4-year cycle (incl. 1 leap)
+      32044, // Fliegel–van Flandern JDN epoch shift
+      1721425, // JDN of 0001‑01‑01 (Gregorian)
+      1721119, // alt epoch offset
+      2400000, // MJD → JDN conversion
+      2400001, // alt MJD → JDN conversion
+      2141, // fixed‑point month/day extraction
+      65536, // observed in some conversions
+      7834, // observed in some conversions
+      256, // observed in some conversions
+      292275056, // qdatetime.h Qt Core year range first year constant
+      292278994, // qdatetime.h Qt Core year range last year constant
+      1601, // Windows FILETIME epoch start year
+      1970, // Unix epoch start year
+      70, // Unix epoch start year short form
+      1899, // Observed in uses with 1900 to address off by one scenarios
+      1900, // Used when converting a 2 digit year
+      2000, // Used when converting a 2 digit year
+      1400, // Hijri base year, used when converting a 2 digit year
+      1980, // FAT filesystem epoch start year
+      227013, // constant observed for Hirji year conversion, and Hirji years are not applicable for gregorian leap year
+      10631, // constant observed for Hirji year conversion, and Hirji years are not applicable for gregorian leap year
+      0
+    ]
   )
 }