JS: Update ConditionalBypassQuery.qll

asgerf · asgerf · commit 29da1fb6c8cd · 2025-01-20T11:20:30.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll
@@ -26,11 +26,7 @@ module ConditionalBypassConfig implements DataFlow::ConfigSig {
   }
 
   predicate observeDiffInformedIncrementalMode() {
-    // TODO(diff-informed): Manually verify if config can be diff-informed.
-    // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:104: Flow call outside 'select' clause
-    // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:113: Flow call outside 'select' clause
-    // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:115: Flow call outside 'select' clause
-    none()
+    none() // Disabled since the enclosing comparison is sometimes selected instead of the sink
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,7 @@ module ConditionalBypassConfig implements DataFlow::ConfigSig {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`predicate observeDiffInformedIncrementalMode() {`
`29`		`- // TODO(diff-informed): Manually verify if config can be diff-informed.`
`30`		`- // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:104: Flow call outside 'select' clause`
`31`		`- // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:113: Flow call outside 'select' clause`
`32`		`- // ql/lib/semmle/javascript/security/dataflow/ConditionalBypassQuery.qll:115: Flow call outside 'select' clause`
`33`		`- none()`
	`29`	`+ none() // Disabled since the enclosing comparison is sometimes selected instead of the sink`
`34`	`30`	`}`
`35`	`31`	`}`
`36`	`32`