PS: Fix bug in 'getConstructedTypeExpr' and add a helper predicate to 'ObjectCreationNode'.

Author: MathiasVP

powershell/ql/lib/semmle/code/powershell/ast/internal/ObjectCreation.qll

@@ -46,12 +46,11 @@ class DotNetObjectCreation extends AbstractObjectCreation, CmdCall {
 
   final override Expr getConstructedTypeExpr() {
     // Either it's the named argument `TypeName`
-    result = CmdCall.super.getNamedArgument("TypeName")
+    result = CmdCall.super.getNamedArgument("typename")
     or
     // Or it's the first positional argument if that's the named argument
-    not CmdCall.super.hasNamedArgument("TypeName") and
-    result = CmdCall.super.getPositionalArgument(0) and
-    result = CmdCall.super.getNamedArgument(["ArgumentList", "Property"])
+    not CmdCall.super.hasNamedArgument("typename") and
+    result = CmdCall.super.getPositionalArgument(0)
   }
 }
 

powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPublic.qll

@@ -500,6 +500,10 @@ class ObjectCreationNode extends CallNode {
   string getAConstructedTypeName() {
     result = this.getObjectCreationNode().getAConstructedTypeName()
   }
+
+  string getLowerCaseConstructedTypeName() {
+    result = this.getObjectCreationNode().getLowerCaseConstructedTypeName()
+  }
 }
 
 /** A call, viewed as a node in a data flow graph. */