C/C++ : FIx the research for UInt16, 32 and 64 + Fix 2 first line of the query

Author: thibaut hansmann

cpp/ql/src/experimental/Best Practices/WrongUintAccess.ql

@@ -10,18 +10,18 @@
 import cpp
 
 from
-  Variable var, ArrayExpr useExpr, VariableDeclarationEntry def, ArrayType defLine, VariableAccess use
+  Variable var, ArrayExpr useExpr, VariableDeclarationEntry def, ArrayType defLine,
+  VariableAccess use
 where
-  def = defLine.getATypeNameUse() and
-  var = def.getDeclaration() and
+  var.getUnspecifiedType() = defLine and
   use = useExpr.getArrayBase() and
-  var = use.getTarget() and (
-  (useExpr.getArrayOffset().getType() instanceof UInt16_t and
-  defLine.getArraySize() <= 256) or
-  (useExpr.getArrayOffset().getType() instanceof UInt32_t and
-  defLine.getArraySize() <= 900) or
-  (useExpr.getArrayOffset().getType() instanceof UInt64_t and
-  defLine.getArraySize() <= 1000)
-  )
-select useExpr, "Using a " + useExpr.getArrayOffset().getType() +" to acess the array $@ of size " + defLine.getArraySize() + ".", var,
-  var.getName()
+  var = use.getTarget() and
+  (
+    useExpr.getArrayOffset().getType() instanceof UInt16_t or
+    useExpr.getArrayOffset().getType() instanceof UInt32_t or
+    useExpr.getArrayOffset().getType() instanceof UInt64_t
+  ) and
+  defLine.getArraySize() <= 256
+select useExpr,
+  "Using a " + useExpr.getArrayOffset().getType() + " to acess the array $@ of size " +
+    defLine.getArraySize() + ".", var, var.getName()