Skip to content

Commit 3104f8a

Browse files
committed
Remove Fields in PostMessageEvent
1 parent 68b2a6c commit 3104f8a

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

javascript/ql/src/experimental/Security/CWE-020/PostMessageNoOriginCheck.ql

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class InsufficientOriginChecks extends DataFlow::MethodCallNode {
3333
* A function handler for the `MessageEvent`.
3434
*/
3535
class PostMessageHandler extends DataFlow::FunctionNode {
36-
PostMessageHandler() { this.getFunction() instanceof PostMessageEventHandler }
36+
PostMessageHandler() { this.getFunction() instanceof PostMessageEventHandler }
3737
}
3838

3939
/**
@@ -42,16 +42,13 @@ class PostMessageHandler extends DataFlow::FunctionNode {
4242
class PostMessageEvent extends DataFlow::SourceNode {
4343
PostMessageEvent() { exists(PostMessageHandler handler | this = handler.getParameter(0)) }
4444

45-
VarAccess event;
46-
EqualityTest astNode;
47-
4845
/**
4946
* Holds if an access on `MessageEvent.origin` is in an `EqualityTest` and there is no call of an insufficient verification method on `MessageEvent.origin`
5047
*/
5148
predicate hasOriginChecked() {
5249
exists(EqualityTest test |
5350
this.getAPropertyRead(["origin", "source"]).flowsToExpr(test.getAnOperand())
54-
)
51+
)
5552
}
5653

5754
/**

0 commit comments

Comments
 (0)