C#: Base Useless Code tests on stubs.

michaelnebel · michaelnebel · commit 35a1dd8ba98a · 2023-08-29T16:20:59.000+02:00
diff --git a/csharp/ql/test/query-tests/Useless Code/DefaultToString/DefaultToString.ql b/csharp/ql/test/query-tests/Useless Code/DefaultToString/DefaultToString.ql
@@ -8,7 +8,7 @@ class MyDefaultToStringType extends DefaultToStringType {
     string filepath, int startline, int startcolumn, int endline, int endcolumn
   ) {
     exists(Location l | l = this.getLocation() |
-      if l instanceof SourceLocation
+      if this.fromSource()
       then l.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
       else
         any(EmptyLocation el).hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
diff --git a/csharp/ql/test/query-tests/Useless Code/DefaultToString/options b/csharp/ql/test/query-tests/Useless Code/DefaultToString/options
@@ -1 +1,2 @@
-semmle-extractor-options: /r:System.Runtime.Extensions.dll
+semmle-extractor-options: /nostdlib /noconfig
+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
diff --git a/csharp/ql/test/query-tests/Useless Code/IntGetHashCode/options b/csharp/ql/test/query-tests/Useless Code/IntGetHashCode/options
@@ -0,0 +1,2 @@
+semmle-extractor-options: /nostdlib /noconfig
+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
diff --git a/csharp/ql/test/query-tests/Useless Code/PointlessForwardingMethod/options b/csharp/ql/test/query-tests/Useless Code/PointlessForwardingMethod/options
@@ -0,0 +1,2 @@
+semmle-extractor-options: /nostdlib /noconfig
+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
diff --git a/csharp/ql/test/query-tests/Useless Code/RedundantToStringCall/options b/csharp/ql/test/query-tests/Useless Code/RedundantToStringCall/options
@@ -0,0 +1,2 @@
+semmle-extractor-options: /nostdlib /noconfig
+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
diff --git a/csharp/ql/test/query-tests/Useless Code/UnusedLabel/options b/csharp/ql/test/query-tests/Useless Code/UnusedLabel/options
@@ -0,0 +1,2 @@
+semmle-extractor-options: /nostdlib /noconfig
+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`		`-semmle-extractor-options: /r:System.Runtime.Extensions.dll`
	`1`	`+semmle-extractor-options: /nostdlib /noconfig`
	`2`	`+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+semmle-extractor-options: /nostdlib /noconfig`
	`2`	`+semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj`