Merge pull request #16311 from tamasvajk/fix/resx

tamasvajk · web-flow · commit 3b44b131b9fa · 2024-04-24T13:49:55.000+02:00
C#: Do not download `Microsoft.CodeAnalysis.ResxSourceGenerator` when…
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/ResxGenerator.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/ResxGenerator.cs
@@ -19,6 +19,13 @@ public ResxGenerator(
             TemporaryDirectory tempWorkingDirectory,
             IEnumerable<string> references) : base(fileProvider, fileContent, dotnet, compilationInfoContainer, logger, tempWorkingDirectory, references)
         {
+            if (fileProvider.Resources.Count == 0)
+            {
+                logger.LogDebug("No resources found, skipping resource extraction.");
+                sourceGeneratorFolder = null;
+                return;
+            }
+
             try
             {
                 // The package is downloaded to `missingpackages`, which is okay, we're already after the DLL collection phase.

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,13 @@ public ResxGenerator(`
`19`	`19`	`TemporaryDirectory tempWorkingDirectory,`
`20`	`20`	`IEnumerable<string> references) : base(fileProvider, fileContent, dotnet, compilationInfoContainer, logger, tempWorkingDirectory, references)`
`21`	`21`	`{`
	`22`	`+ if (fileProvider.Resources.Count == 0)`
	`23`	`+ {`
	`24`	`+ logger.LogDebug("No resources found, skipping resource extraction.");`
	`25`	`+ sourceGeneratorFolder = null;`
	`26`	`+ return;`
	`27`	`+ }`
	`28`	`+`
`22`	`29`	`try`
`23`	`30`	`{`
`24`	`31`	// The package is downloaded to `missingpackages`, which is okay, we're already after the DLL collection phase.