Add flow through string concatenation

owen-mc · owen-mc · commit 3ef7a0932ad9 · 2024-04-24T14:19:25.000+01:00
diff --git a/go/ql/src/Security/CWE-020/IncompleteHostnameRegexp.ql b/go/ql/src/Security/CWE-020/IncompleteHostnameRegexp.ql
@@ -101,6 +101,10 @@ module IncompleteHostNameRegexpConfig implements DataFlow::ConfigSig {
     ) and
     not regexpGuardsError(sink)
   }
+
+  predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
+    StringOps::Concatenation::taintStep(node1, node2)
+  }
 }
 
 module Flow = DataFlow::Global<IncompleteHostNameRegexpConfig>;

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,10 @@ module IncompleteHostNameRegexpConfig implements DataFlow::ConfigSig {`
`101`	`101`	`) and`
`102`	`102`	`not regexpGuardsError(sink)`
`103`	`103`	`}`
	`104`	`+`
	`105`	`+ predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {`
	`106`	`+ StringOps::Concatenation::taintStep(node1, node2)`
	`107`	`+ }`
`104`	`108`	`}`
`105`	`109`
`106`	`110`	`module Flow = DataFlow::Global<IncompleteHostNameRegexpConfig>;`