Dataflow: Slight join improvement.

aschackmull · aschackmull · commit 3ffc61617906 · 2025-01-16T16:22:55.000+01:00
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -2154,8 +2154,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
         pragma[nomagic]
         private predicate storeStepFwd(NodeEx node1, Ap ap1, Content c, NodeEx node2, Ap ap2) {
           fwdFlowStore(node1, _, ap1, _, c, _, _, node2, _, _, _) and
-          ap2 = apCons(c, ap1) and
-          readStepFwd(_, ap2, c, _, _)
+          readStepFwd(_, ap2, c, _, ap1)
         }
 
         pragma[nomagic]

Original file line number	Diff line number	Diff line change
`@@ -2154,8 +2154,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`2154`	`2154`	`pragma[nomagic]`
`2155`	`2155`	`private predicate storeStepFwd(NodeEx node1, Ap ap1, Content c, NodeEx node2, Ap ap2) {`
`2156`	`2156`	`fwdFlowStore(node1, _, ap1, _, c, _, _, node2, _, _, _) and`
`2157`		`- ap2 = apCons(c, ap1) and`
`2158`		`- readStepFwd(_, ap2, c, _, _)`
	`2157`	`+ readStepFwd(_, ap2, c, _, ap1)`
`2159`	`2158`	`}`
`2160`	`2159`
`2161`	`2160`	`pragma[nomagic]`