Merge pull request #11030 from MathiasVP/fix-ql-for-ql-errors

MathiasVP · web-flow · commit 42e8ec32d7ac · 2022-10-28T13:39:50.000+02:00
C++: Fix QL-for-QL in #10817
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
@@ -855,8 +855,6 @@ private class IndirectOperandIndirectExprNode extends IndirectExprNodeBase, Indi
     this.getIndirectionIndex() = index and
     result = this.getConvertedExpr(index).getUnconverted()
   }
-
-  final override string toStringImpl() { result = super.toStringImpl() }
 }
 
 private class IndirectInstructionIndirectExprNode extends IndirectExprNodeBase, IndirectInstruction {
@@ -871,8 +869,6 @@ private class IndirectInstructionIndirectExprNode extends IndirectExprNodeBase,
     this.getIndirectionIndex() = index and
     result = this.getConvertedExpr(index).getUnconverted()
   }
-
-  final override string toStringImpl() { result = super.toStringImpl() }
 }
 
 private class IndirectArgumentOutExprNode extends ExprNodeBase, IndirectArgumentOutNode {

Original file line number	Diff line number	Diff line change
`@@ -855,8 +855,6 @@ private class IndirectOperandIndirectExprNode extends IndirectExprNodeBase, Indi`
`855`	`855`	`this.getIndirectionIndex() = index and`
`856`	`856`	`result = this.getConvertedExpr(index).getUnconverted()`
`857`	`857`	`}`
`858`		`-`
`859`		`- final override string toStringImpl() { result = super.toStringImpl() }`
`860`	`858`	`}`
`861`	`859`
`862`	`860`	`private class IndirectInstructionIndirectExprNode extends IndirectExprNodeBase, IndirectInstruction {`
`@@ -871,8 +869,6 @@ private class IndirectInstructionIndirectExprNode extends IndirectExprNodeBase,`
`871`	`869`	`this.getIndirectionIndex() = index and`
`872`	`870`	`result = this.getConvertedExpr(index).getUnconverted()`
`873`	`871`	`}`
`874`		`-`
`875`		`- final override string toStringImpl() { result = super.toStringImpl() }`
`876`	`872`	`}`
`877`	`873`
`878`	`874`	`private class IndirectArgumentOutExprNode extends ExprNodeBase, IndirectArgumentOutNode {`